-
Notifications
You must be signed in to change notification settings - Fork 201
Update pathing to FV3 dir (now UFSATM) and update CDMBGWD var name #4045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pathing to FV3 dir (now UFSATM) and update CDMBGWD var name #4045
Conversation
Update: This was tested using the ufs-community/ufs-weather-model@5e3a925 hash. Some of the CI/CD tests ran to completion. Other tests (the ones with DA) failed. I believe this is due to lack of permissions on my end and the UFS model seems to have run successfully. I'm looking through the logs to confirm. RUNTESTS dir: |
I think the things that failed were due to lack of rstprod access.. I'll launch generate workflows from gaeac6 |
Gaea tests will be running here after building: /gpfs/f6/ira-sti/world-shared/Jessica.Meixner/gwpr4045/test01 |
Output from GaeaC6:
@dpsarmie I think your PR can be marked as ready for review. @DavidHuber-NOAA please let me know if additional help is needed running CI on additional platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @dpsarmie!
@JessicaMeixner-NOAA Thanks for testing on WCOSS2! I'll mark this as passed on that platform. There's no need to manually test this on other platforms. @TerrenceMcGuinness-NOAA has enabled automated CI on all tier-1 and tier-2 platforms (thanks!) except Ursa, which is a WIP, and can be excused for this PR. Launching CI on C6, Hera, and Hercules. |
@DavidHuber-NOAA - I tested on GaeaC6 not WCOSS2 Would you like me to test this on WCOSS2? Do you need to re-run the GaeaC6 tests? |
@JessicaMeixner-NOAA Apologies, I misread your message. No need to re-test on C6. I'll cancel that pipeline and mark it as passed. |
@JessicaMeixner-NOAA Yes, please go ahead and test this on WCOSS2. Thanks! |
WCOSS2 is building, tests will be at: /lfs/h2/emc/couple/noscrub/jessica.meixner/gwpr4045/t4045 |
C96C48_hybatmDA FAILED on Hercules (pipeline ID: 4170) In directory: Error Log Files:
View Error Logs: (enkfgdas_esfc.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
@JessicaMeixner-NOAA Just as a point-of-order, you might want to update your case status script with the hostname and path for edification purposes please. It's just easier for me to keep track when cross-referencing the actual pipeline runs. Also its just a slight malaprop to "mark" PR as passed with pipeline labels (we're trying to maybe find a better way to communicate that soon) |
The
We can ignore Hercules for now. I'll report this error to RDHPCS. |
C96C48mx500_S2SW_cyc_gfs FAILED on Hercules (pipeline ID: 4170) In directory: Error Log Files:
View Error Logs: (enkfgfs_esfc.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
Status update from WCOSS2 - All tests have passed - except for C96_atm3DVar_extended which is still running. Update:
|
All tests have passed on Hera except C96C48mx500_S2SW_cyc_gfs, which is still running. Only the following jobs remain:
|
@DavidHuber-NOAA I can see now we should put in another feature request where we can get these status outputs from the pipeline on demand by issue comment requests directly here in the PR feed like this:
|
I think my poking around at Hera's CI system caused it to hang. All tasks completed except the last |
WCOSS2 tests passed:
|
Description
As of ufs-community/ufs-weather-model@688de8e, there are two changes that occurred in the UFS namelists and FV3 pathing that need to be reflected in the Global Workflow scripts.
ufs-community/ufs-weather-model#2788 : This PR changed the namelist variable
CDMBWD
toCDMBGWD
. This fix is just a typo in the namelist that was finally corrected. No changes in model results or behavior resulted from this fix.ufs-community/ufs-weather-model#2780 (ufs-community/ufs-weather-model@d4bac23) : When MPAS was added to the UFS, a change was made to the directory/submodule naming. We decided to rename
./FV3/
to./UFSATM/
.There are a few scripts where
./ufs_model.fd/FV3/
is referenced and those will need to be changed to./ufs_model.fd/UFSATM/
. Again, no changes in model results or behavior should result from this update.Dependencies:
UFS hash in GW needs to be ufs-community/ufs-weather-model@688de8e or later. This will need to be added when the hash is updated. If this is added before the hash update or after the hash update, then the GW will lose functionality.
Closes #4014
Closes #4017
Type of change
Change characteristics
How has this been tested?
This will be tested on URSA by running the full CI/CD suite. (UFS model only, no post-processing)
Checklist