[mysql] Set HikariCP's minimumIdle to 1 to reduce connection size #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiabao-Sun
force-pushed
the
minimum-idle
branch
from
828fd73 to
15f7dca
Compare
Jiabao-Sun
changed the title
leonardBang
reviewed
Dec 15, 2021
| @@ -30,6 +30,7 @@ | |||
| "jdbc:mysql://%s:%s/?useInformationSchema=true&nullCatalogMeansCurrent=false&useUnicode=true&characterEncoding=UTF-8&characterSetResults=UTF-8&zeroDateTimeBehavior=CONVERT_TO_NULL"; | |||
| public static final String CONNECTION_POOL_PREFIX = "connection-pool-"; | |||
| public static final String SERVER_TIMEZONE_KEY = "serverTimezone"; | |||
| public static final int MINIMUM_IDLE_SIZE = 1; | |||
There was a problem hiding this comment.
how about MINIMUM_POOL_SIZE ?
There was a problem hiding this comment.
Thanks @leonardBang, renamed.
leonardBang
approved these changes
Dec 16, 2021
leonardBang
pushed a commit
to leonardBang/flink-cdc-connectors
that referenced
this pull request
Dec 16, 2021
leonardBang
pushed a commit
that referenced
this pull request
Dec 16, 2021
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set HikariCP's minimumIdle to 1 to reduce connections size.