Skip to content

[mysql] Set HikariCP's minimumIdle to 1 to reduce connection size #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2021
Merged

[mysql] Set HikariCP's minimumIdle to 1 to reduce connection size #692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f7dca
[mysql] Set HikariCP's minimumIdle to 1 to reduce connection size
Jiabao-Sun Dec 8, 2021
168b326
renamed to MINIMUM_POOL_SIZE
Jiabao-Sun Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...in/java/com/ververica/cdc/connectors/mysql/source/connection/PooledDataSourceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public class PooledDataSourceFactory {
"jdbc:mysql://%s:%s/?useInformationSchema=true&nullCatalogMeansCurrent=false&useUnicode=true&characterEncoding=UTF-8&characterSetResults=UTF-8&zeroDateTimeBehavior=CONVERT_TO_NULL";
public static final String CONNECTION_POOL_PREFIX = "connection-pool-";
public static final String SERVER_TIMEZONE_KEY = "serverTimezone";
public static final int MINIMUM_POOL_SIZE = 1;

private PooledDataSourceFactory() {}

Expand All @@ -43,6 +44,7 @@ public static HikariDataSource createPooledDataSource(MySqlSourceConfig sourceCo
config.setJdbcUrl(String.format(JDBC_URL_PATTERN, hostName, port));
config.setUsername(sourceConfig.getUsername());
config.setPassword(sourceConfig.getPassword());
config.setMinimumIdle(MINIMUM_POOL_SIZE);
config.setMaximumPoolSize(sourceConfig.getConnectionPoolSize());
config.setConnectionTimeout(sourceConfig.getConnectTimeout().toMillis());
config.addDataSourceProperty(SERVER_TIMEZONE_KEY, sourceConfig.getServerTimeZone());
Expand Down