Skip to content

disable uploading source maps for deploying single function #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −8
Open

disable uploading source maps for deploying single function #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dist/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,15 @@ export declare class SentryPlugin implements Plugin {
sentry: Partial<SentryOptions>;
serverless: Serverless;
options: Serverless.Options;
logging: Plugin.Logging;
custom: Service.Custom;
hooks: {
[event: string]: (...rest: any[]) => any;
};
provider: Aws;
validated: boolean;
isInstrumented: boolean;
constructor(serverless: Serverless, options: Serverless.Options);
constructor(serverless: Serverless, options: Serverless.Options, logging: Plugin.Logging);
configPlugin(): void;
validate(): Promise<void>;
instrumentFunction(originalDefinition: Serverless.FunctionDefinition, setEnv: boolean): FunctionDefinitionWithSentry;
Expand Down
13 changes: 8 additions & 5 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,11 @@ var _e = encodeURIComponent;
* Serverless Plugin forward Lambda exceptions to Sentry (https://sentry.io)
*/
var SentryPlugin = /** @class */ (function () {
function SentryPlugin(serverless, options) {
function SentryPlugin(serverless, options, logging) {
var _this = this;
this.serverless = serverless;
this.options = options;
this.logging = logging;
this.custom = this.serverless.service.custom;
this.provider = this.serverless.getProvider("aws");
// Create schema for our properties. For reference use https://github.com/ajv-validator/ajv
Expand Down Expand Up @@ -179,11 +180,13 @@ var SentryPlugin = /** @class */ (function () {
case 0: return [4 /*yield*/, this.createSentryRelease()];
case 1:
_a.sent();
return [4 /*yield*/, this.uploadSentrySourcemaps()];
case 2:
_a.sent();
// uploading sentry source maps doesn't work for "deploy function" command #67
// TODO to add proper fix once it's addressed on serverless-core https://github.com/serverless/serverless/issues/11179
this.logging.log.warning('Uploading source maps is skipped for "deploy function" because it is not working');
// await this.uploadSentrySourcemaps();
return [4 /*yield*/, this.deploySentryRelease()];
case 3:
case 2:
// await this.uploadSentrySourcemaps();
_a.sent();
return [2 /*return*/];
}
Expand Down
9 changes: 7 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,17 @@ export class SentryPlugin implements Plugin {
sentry: Partial<SentryOptions>;
serverless: Serverless;
options: Serverless.Options;
logging: Plugin.Logging;
custom: Service.Custom;
hooks: { [event: string]: (...rest: any[]) => any };
provider: Aws;
validated: boolean;
isInstrumented: boolean;

constructor(serverless: Serverless, options: Serverless.Options) {
constructor(serverless: Serverless, options: Serverless.Options, logging: Plugin.Logging) {
this.serverless = serverless;
this.options = options;
this.logging = logging;
this.custom = this.serverless.service.custom;
this.provider = this.serverless.getProvider("aws");

Expand Down Expand Up @@ -162,7 +164,10 @@ export class SentryPlugin implements Plugin {

"after:deploy:function:deploy": async () => {
await this.createSentryRelease();
await this.uploadSentrySourcemaps();
// uploading sentry source maps doesn't work for "deploy function" command #67
// TODO to add proper fix once it's addressed on serverless-core https://github.com/serverless/serverless/issues/11179
this.logging.log.warning('Uploading source maps is skipped for "deploy function" because it is not working');
// await this.uploadSentrySourcemaps();
await this.deploySentryRelease();
},

Expand Down