Return support for em_http_request
#1103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koilanetroc
force-pushed
the
return-em-http-request-support
branch
2 times, most recently
from
62b081a to
cd49bd1
Compare
|
Seems like currently something is off with CI, I tested a dummy change(only changed a line in readme) and CI was red anyway, also failures seems to be unrelated to my changes. |
|
@koic, as I see recent PRs were merged by you, maybe you could have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 3.24.0 support for
em_http_requestwas dropped due to:The problem was addressed in igrigorik/em-http-request#354 and now cookiejar supports ruby 3.3+, it was added in this commit.
Therefore I'm returning back support for
em_http_requestwhich was disabled in #1070