Skip to content

Return support for em_http_request #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return support for em_http_request #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/webmock/http_lib_adapters/em_http_request_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

return if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.4.0')

begin
require 'em-http-request'
rescue LoadError
Expand Down
4 changes: 0 additions & 4 deletions spec/acceptance/em_http_request/em_http_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
describe "EM::HttpRequest" do
include EMHttpRequestSpecHelper

before(:all) do
skip 'em-http-request is not supported on Ruby >= 3.4' if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.4.0')
end

include_context "with WebMock", :no_status_message

#functionality only supported for em-http-request 1.x
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
require 'curb'
require 'patron'
require 'typhoeus'
require 'em-http'
end
if RUBY_PLATFORM =~ /java/
require 'manticore'
Expand Down
Loading