linters: take the golangci-lint v2 bump opportunity to enable more linters #3608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
approved these changes
Apr 8, 2025
This linter checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/golangci-lint-v2-enable-more-linters
branch
from
af6c896 to
4283762
Compare
Errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13. Signed-off-by: Mahe Tardy <[email protected]>
A dedicated linter is doing what we were trying to enforce with gomodguard. Signed-off-by: Mahe Tardy <[email protected]>
Intrange is a linter to find places where for loops could make use of an integer range. Signed-off-by: Mahe Tardy <[email protected]>
Reports wrong mirror patterns of bytes/strings usage. Signed-off-by: Mahe Tardy <[email protected]>
Checks that fmt.Sprintf can be replaced with a faster alternative. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/golangci-lint-v2-enable-more-linters
branch
from
4283762 to
9495b2a
Compare
Loggercheck checks for odd number of key and value pairs for common logger libraries such as klog. Fix three minor log bugs in which we did not use klog correctly. Signed-off-by: Mahe Tardy <[email protected]>
olsajiri
approved these changes
Apr 9, 2025
|
@olsajiri I can wait for you to merge the tracepoint before merging this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #3607, adding new linters to simplify the codebase and/or fix it in some places.
I know this can make backports a bit annoying but the change should always be quite straightforward and I personally think linters are useful in two aspect: welcoming new contributors by enforcing automatic rules (thus reducing style friction) and finding actual issues.
Most of the linters I added can fix their own issues with
golangci-lint run --fix.