chore: upgrade to Rust 1.90 #30793
Open
chore: upgrade to Rust 1.90 #30793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Sep 19, 2025
| // The caller must validate these cases. | ||
| assert!(args.length > 0); | ||
| assert!(args.length % 8 == 0); | ||
| assert!(args.length.is_multiple_of(8)); |
littledivy
reviewed
Sep 23, 2025
There was a problem hiding this comment.
The zlib test is failing because this is UB:
Line 756 in 9c04b88
It should be changed to a match instead.
littledivy
force-pushed
the
rust_1900
branch
from
fd3c54c to
f6331ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.