chore: upgrade to Rust 1.90

.github/workflows/ci.generate.ts

@@ -5,7 +5,7 @@ import { stringify } from "jsr:@std/yaml@^0.221/stringify";
 // Bump this number when you want to purge the cache.
 // Note: the tools/release/01_bump_crate_versions.ts script will update this version
 // automatically via regex, so ensure that this line maintains this format.
-const cacheVersion = 73;
+const cacheVersion = 74;
 
 const ubuntuX86Runner = "ubuntu-24.04";
 const ubuntuX86XlRunner = "ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04";

.github/workflows/ci.yml

@@ -188,8 +188,8 @@ jobs:
             ~/.cargo/registry/index
             ~/.cargo/registry/cache
             ~/.cargo/git/db
-          key: '73-cargo-home-${{ matrix.os }}-${{ matrix.arch }}-${{ hashFiles(''Cargo.lock'') }}'
-          restore-keys: '73-cargo-home-${{ matrix.os }}-${{ matrix.arch }}-'
+          key: '74-cargo-home-${{ matrix.os }}-${{ matrix.arch }}-${{ hashFiles(''Cargo.lock'') }}'
+          restore-keys: '74-cargo-home-${{ matrix.os }}-${{ matrix.arch }}-'
         if: '!(matrix.skip)'
       - uses: dsherret/rust-toolchain-file@v1
         if: '!(matrix.skip)'
@@ -391,7 +391,7 @@ jobs:
             !./target/*/*.zip
             !./target/*/*.tar.gz
           key: never_saved
-          restore-keys: '73-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-'
+          restore-keys: '74-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-'
       - name: Apply and update mtime cache
         if: '!(matrix.skip) && (!startsWith(github.ref, ''refs/tags/''))'
         uses: ./.github/mtime_cache
@@ -772,7 +772,7 @@ jobs:
             !./target/*/gn_root
             !./target/*/*.zip
             !./target/*/*.tar.gz
-          key: '73-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}'
+          key: '74-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}'
   libs:
     name: build libs
     needs:

cli/cdp.rs

@@ -361,6 +361,8 @@ pub struct StartPreciseCoverageArgs {
   pub allow_triggered_updates: bool,
 }
 
+// TODO(bartlomieju): in Rust 1.90 some structs started getting flagged as not used
+#[allow(dead_code)]
 /// <https://chromedevtools.github.io/devtools-protocol/tot/Profiler/#method-startPreciseCoverage>
 #[derive(Debug, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]

cli/lsp/tsc.rs

@@ -2167,6 +2167,8 @@ impl DocumentSpan {
   }
 }
 
+// TODO(bartlomieju): in Rust 1.90 some structs started getting flagged as not used
+#[allow(dead_code)]
 #[derive(Debug, Clone, Deserialize)]
 pub enum MatchKind {
   #[serde(rename = "exact")]

cli/tools/bundle/mod.rs

@@ -801,6 +801,8 @@ impl DenoPluginHandler {
   }
 }
 
+// TODO(bartlomieju): in Rust 1.90 some structs started getting flagged as not used
+#[allow(dead_code)]
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 #[serde(rename_all = "kebab-case")]
 enum PluginImportKind {
@@ -831,6 +833,8 @@ impl From<protocol::ImportKind> for PluginImportKind {
   }
 }
 
+// TODO(bartlomieju): in Rust 1.90 some structs started getting flagged as not used
+#[allow(dead_code)]
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 #[serde(rename_all = "camelCase")]
 struct PluginOnResolveArgs {
@@ -842,6 +846,8 @@ struct PluginOnResolveArgs {
   with: IndexMap<String, String>,
 }
 
+// TODO(bartlomieju): in Rust 1.90 some structs started getting flagged as not used
+#[allow(dead_code)]
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 #[serde(rename_all = "camelCase")]
 struct PluginOnLoadArgs {

cli/tools/test/mod.rs

@@ -493,6 +493,8 @@ pub struct TestPlan {
   pub used_only: bool,
 }
 
+// TODO(bartlomieju): in Rust 1.90 some structs started getting flagged as not used
+#[allow(dead_code)]
 #[derive(Debug, Copy, Clone, Eq, PartialEq, Deserialize)]
 pub enum TestStdioStream {
   Stdout,

cli/tools/test/reporters/dot.rs

@@ -41,7 +41,7 @@ impl DotTestReporter {
       return;
     }
 
-    if self.n != 0 && self.n % self.width == 0 {
+    if self.n != 0 && self.n.is_multiple_of(self.width) {
       println!();
     }
     self.n += 1;

ext/crypto/generate_key.rs

@@ -137,7 +137,7 @@ fn generate_key_ec(
 }
 
 fn generate_key_aes(length: usize) -> Result<Vec<u8>, GenerateKeyError> {
-  if length % 8 != 0 || length > 256 {
+  if !length.is_multiple_of(8) || length > 256 {
     return Err(GenerateKeyError::InvalidAESKeyLength);
   }
 

ext/crypto/key.rs

@@ -9,14 +9,6 @@ use aws_lc_rs::signature::EcdsaVerificationAlgorithm;
 use serde::Deserialize;
 use serde::Serialize;
 
-#[derive(Serialize, Deserialize, Copy, Clone)]
-#[serde(rename_all = "camelCase")]
-pub enum KeyType {
-  Public,
-  Private,
-  Secret,
-}
-
 #[derive(Serialize, Deserialize, Copy, Clone, Eq, PartialEq)]
 pub enum CryptoHash {
   #[serde(rename = "SHA-1")]
@@ -98,19 +90,6 @@ impl hkdf::KeyType for HkdfOutput<usize> {
   }
 }
 
-#[derive(Serialize, Deserialize, Copy, Clone, Debug, Eq, PartialEq)]
-#[serde(rename_all = "camelCase")]
-pub enum KeyUsage {
-  Encrypt,
-  Decrypt,
-  Sign,
-  Verify,
-  DeriveKey,
-  DeriveBits,
-  WrapKey,
-  UnwrapKey,
-}
-
 #[derive(Serialize, Deserialize, Clone, Copy)]
 pub enum Algorithm {
   #[serde(rename = "RSASSA-PKCS1-v1_5")]

ext/crypto/lib.rs

@@ -595,7 +595,7 @@ pub async fn op_crypto_derive_bits(
         let salt = &*zero_copy;
         // The caller must validate these cases.
         assert!(args.length > 0);
-        assert!(args.length % 8 == 0);
+        assert!(args.length.is_multiple_of(8));
 
         let algorithm = match args.hash.ok_or_else(JsErrorBox::not_supported)? {
           CryptoHash::Sha1 => pbkdf2::PBKDF2_HMAC_SHA1,
@@ -791,7 +791,7 @@ pub fn op_crypto_wrap_key(
     Algorithm::AesKw => {
       let key = args.key.as_secret_key()?;
 
-      if data.len() % 8 != 0 {
+      if !data.len().is_multiple_of(8) {
         return Err(CryptoError::DataInvalidSize);
       }
 
@@ -820,7 +820,7 @@ pub fn op_crypto_unwrap_key(
     Algorithm::AesKw => {
       let key = args.key.as_secret_key()?;
 
-      if data.len() % 8 != 0 {
+      if !data.len().is_multiple_of(8) {
         return Err(CryptoError::DataInvalidSize);
       }
 

ext/net/tunnel.rs

@@ -169,6 +169,7 @@ impl Resource for TunnelStreamResource {
   }
 }
 
+#[allow(dead_code)]
 #[derive(Debug, serde::Serialize, serde::Deserialize)]
 enum StreamHeader {
   Control {
@@ -183,6 +184,7 @@ enum StreamHeader {
   Agent {},
 }
 
+#[allow(dead_code)]
 #[derive(Debug, serde::Serialize, serde::Deserialize)]
 enum ControlMessage {
   Authenticated {

ext/node/ops/crypto/cipher.rs

@@ -292,25 +292,25 @@ impl Cipher {
     use Cipher::*;
     match self {
       Aes128Cbc(encryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           encryptor.encrypt_block_b2b_mut(input.into(), output.into());
         }
       }
       Aes128Ecb(encryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           encryptor.encrypt_block_b2b_mut(input.into(), output.into());
         }
       }
       Aes192Ecb(encryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           encryptor.encrypt_block_b2b_mut(input.into(), output.into());
         }
       }
       Aes256Ecb(encryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           encryptor.encrypt_block_b2b_mut(input.into(), output.into());
         }
@@ -324,7 +324,7 @@ impl Cipher {
         cipher.encrypt(output);
       }
       Aes256Cbc(encryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           encryptor.encrypt_block_b2b_mut(input.into(), output.into());
         }
@@ -631,25 +631,25 @@ impl Decipher {
     use Decipher::*;
     match self {
       Aes128Cbc(decryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           decryptor.decrypt_block_b2b_mut(input.into(), output.into());
         }
       }
       Aes128Ecb(decryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           decryptor.decrypt_block_b2b_mut(input.into(), output.into());
         }
       }
       Aes192Ecb(decryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           decryptor.decrypt_block_b2b_mut(input.into(), output.into());
         }
       }
       Aes256Ecb(decryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           decryptor.decrypt_block_b2b_mut(input.into(), output.into());
         }
@@ -663,7 +663,7 @@ impl Decipher {
         decipher.decrypt(output);
       }
       Aes256Cbc(decryptor) => {
-        assert!(input.len() % 16 == 0);
+        assert!(input.len().is_multiple_of(16));
         for (input, output) in input.chunks(16).zip(output.chunks_mut(16)) {
           decryptor.decrypt_block_b2b_mut(input.into(), output.into());
         }

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.89.0"
+channel = "1.90.0"
 components = ["rustfmt", "clippy"]