feat(theme): Add theme-tabs-container stable className #11426
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +3.85 kB (+0.03%) Total Size: 12.1 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +3.88 kB (+0.03%) Total Size: 12.5 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #5468 (reply in thread)
Let's officialize this CSS selector as stable.
It was already stable (#4086) but not "officially". I kept the former class for retro-compatibility, but we'll remove it for Docusaurus v4, as users using undocumented classes are more likely to review their sites on upgrades.
Note: the other tab items do not really need stable class names because they already have good accessibility roles useful for targeting (tab, tablist, tabpanel)
Test Plan
preview
Test links
https://deploy-preview-11426--docusaurus-2.netlify.app/