style(v2): add className to tab container #4086
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 73edd52 https://app.netlify.com/sites/docusaurus-1/deploys/600e881bb401b10007c5658d |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 73edd52 |
|
Size Change: -2 B (0%) Total Size: 27.1 kB ℹ️ View Unchanged
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4086--docusaurus-2.netlify.app/classic/ |
lex111
reviewed
Jan 22, 2021
|
|
||
| return ( | ||
| <div> | ||
| <div className="tabs--container"> |
There was a problem hiding this comment.
updated to a single dash
slorber
added
the
pr: polish
|
thanks 👍 |
|
FYI in Docusaurus v4 we are going to harmonize this CSS class name to See #11426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I like the classic theme and would like to theme the Tabs component. The Tabs component's wrapper div doesn't have a class name on it and that would be useful.
This PR adds a classname. No CSS is added.
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
Ensure there is no side effect: the class name isn't used in the repo