Skip to content

Conversation

jolheiser
Copy link
Member

No description provided.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 25, 2020
Signed-off-by: jolheiser <[email protected]>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8a7fbed). Click here to learn what that means.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10462   +/-   ##
=========================================
  Coverage          ?    43.7%           
=========================================
  Files             ?      586           
  Lines             ?    81411           
  Branches          ?        0           
=========================================
  Hits              ?    35579           
  Misses            ?    41428           
  Partials          ?     4404
Impacted Files Coverage Δ
routers/api/v1/repo/tag.go 86.58% <100%> (ø)
modules/git/repo_tag.go 57.57% <18.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7fbed...6882cad. Read the comment docs.

@jolheiser jolheiser merged commit c161bb0 into go-gitea:master Feb 25, 2020
jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 25, 2020
* Change action GETs to POST

* submite = submit + smite

* No more # href

* Fix test

* Match other tests

* Explicit csrf

Signed-off-by: jolheiser <[email protected]>

Co-authored-by: guillep2k <[email protected]>
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Feb 25, 2020
@jolheiser jolheiser deleted the jolheiser-fix-get branch February 25, 2020 20:45
jolheiser added a commit that referenced this pull request Feb 25, 2020
* Change action GETs to POST

* submite = submit + smite

* No more # href

* Fix test

* Match other tests

* Explicit csrf

Signed-off-by: jolheiser <[email protected]>

Co-authored-by: guillep2k <[email protected]>
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants