Skip to content

Change action GETs to POST (#10462) #10464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

Change action GETs to POST (#10462) #10464

merged 1 commit into from
Feb 25, 2020

Conversation

jolheiser
Copy link
Member

Backport #10462

@jolheiser @guillep2k
Change action GETs to POST (go-gitea#10462)
03cec5a 
* Change action GETs to POST

* submite = submit + smite

* No more # href

* Fix test

* Match other tests

* Explicit csrf

Signed-off-by: jolheiser <[email protected]>

Co-authored-by: guillep2k <[email protected]>
@jolheiser jolheiser added this to the 1.11.2 milestone Feb 25, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2020
@jolheiser jolheiser merged commit 4cb1860 into go-gitea:release/v1.11 Feb 25, 2020
@jolheiser jolheiser deleted the backport-get branch February 25, 2020 21:08
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jolheiser @zeripath @guillep2k @GiteaBot