Improve tile source tooltips #110328
Open
Improve tile source tooltips #110328
+46
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is a source ID any why is it relevant to see for users? |
|
It's useful in code. I have a plugin that swaps some tile IDs and not being able to quickly check ID was a bit cumbersome. Right now you need to locate the tile in TileSet tab, click it and check ID field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It annoyed me that there is no easy way to check tile source's ID in the editor. This PR makes it appear in source's tooltip, and also if it's atlas source with a texture, it shows full texture path:
This required adding a custom ItemList sub-class, so I also moved some initialization code.