Skip to content

Conversation

timothyqiu
Copy link
Member

Closes godotengine/godot-proposals#13110

These two static methods are the opposite of FileAccess.get_file_as_{buffer,string}(). The "store" vs "get" naming is consistent with the non-static version.

The parameters follow the same order as ResourceSaver.save() (as the order was discussed and swapped in 4.0), and are also in the same order as mentioned in the method name.

@timothyqiu timothyqiu added this to the 4.x milestone Sep 9, 2025
@timothyqiu timothyqiu requested review from a team as code owners September 9, 2025 08:51
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Not sure if it's worth adding methods for two lines of script, but since we have get_ variants, it probably makes sense to add store_ as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants