-
Notifications
You must be signed in to change notification settings - Fork 354
Rainbow robotics rby1 #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @dongridong, can you remove the stray files in the test dir? |
Hi @kevinzakka. As requested, I have removed all files in the |
Hi @dongridong, looks like you deleted the entire dir. I was referring to only the pycache files and additional files you had added. Can you please add back the test dir? Also, you need to rebase your branch on top of the latest main! |
45f0b6f
to
03d308d
Compare
I've restored the test/ directory and removed only the unnecessary files. Let me know if there's anything else you'd like me to adjust! |
Hi @kevinzakka. |
Hi @dongridong, it says there are conflicts with the main branch. You need to rebase with main. |
3298792
to
fe8a2c2
Compare
Hi @kevinzakka, Thank you. |
Hi @dongridong, I’ll take a look this week! |
<geom mesh="LINK_2_0" class="collision"/> | ||
<geom mesh="LINK_2_1" class="collision"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<geom mesh="LINK_2_0" class="collision"/> | |
<geom mesh="LINK_2_1" class="collision"/> | |
<geom mesh="LINK_2_0" class="in-model-collision"/> | |
<geom mesh="LINK_2_1" class="in-model-collision"/> |
Without marking this as an in-model collision, the robot ends up yeeting itself and smashing into the ground. After this change, the robot is stable in its starting position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
I hope you're doing well.
I wanted to kindly follow up to ask if there are any additional modifications that need to be made.
I haven’t heard back since the last feedback, so I just wanted to check in.
Wishing you a great day!
Dear Rishi
I have reviewed the points you mentioned, made the necessary changes, and
completed the merge.
Please kindly verify the updates.
Thank you.
2025년 6월 30일 (월) 오후 1:51, Rishi Shah ***@***.***>님이 작성:
… ***@***.**** commented on this pull request.
------------------------------
In rainbow_robotics_rby1/rby1.xml
<#150 (comment)>
:
> + <geom mesh="LINK_2_0" class="collision"/>
+ <geom mesh="LINK_2_1" class="collision"/>
⬇️ Suggested change
- <geom mesh="LINK_2_0" class="collision"/>
- <geom mesh="LINK_2_1" class="collision"/>
+ <geom mesh="LINK_2_0" class="in-model-collision"/>
+ <geom mesh="LINK_2_1" class="in-model-collision"/>
Without marking this as an in-model collision, the robot ends up yeeting
itself and smashing into the ground. After this change, the robot is stable
in its starting position.
—
Reply to this email directly, view it on GitHub
<#150 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWFL4WMDBXEIJH767NZJDMT3GC65FAVCNFSM6AAAAABYI7ZN6KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNRZHA4TGMZRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Dear @kevinzakka. Hope you are doing well. I would appreciate it if you could review once more and update the model accordingly. Best regards, |
Hello, we are the RBY1 Support Team from Rainbow Robotics.
We would like to contribute a simplified MJCF model for the RBY1 robot to support its use in simulations.
Description:
This pull request introduces a simplified MJCF description of the RBY1 robot developed by Rainbow Robotics.
The model includes:
Preprocessed meshes and assets for efficient simulation.
A well-defined rby1.xml MJCF file that:
Key Features:
Additional Work:
License:
This model is distributed under the Apache License 2.0.
If you have any questions, please feel free to contact us at [email protected].
Thank you!