Skip to content

Conversation

dongridong
Copy link
Contributor

Hello, we are the RBY1 Support Team from Rainbow Robotics.
We would like to contribute a simplified MJCF model for the RBY1 robot to support its use in simulations.

Description:
This pull request introduces a simplified MJCF description of the RBY1 robot developed by Rainbow Robotics.

The model includes:
Preprocessed meshes and assets for efficient simulation.

A well-defined rby1.xml MJCF file that:

  • Implements the robot's structure and actuator configurations.
  • Adjusts joint and collision properties for optimal MuJoCo simulation.
  • Compatibility with the original URDF file, enabling smooth transitions between formats.

Key Features:

  • Preprocessed meshes optimized for MuJoCo.
  • Support for free joint movement in 3D space.
  • Streamlined collision handling using classes.

Additional Work:

  • Fixed an issue where the file would not open correctly in MuJoCo 3.2.7.
  • Verified the model using model_test.py.
  • Adjusted armature and damping parameters.
  • Modified the forcelimit parameter.
  • Added the implicitfast integrator option.

License:
This model is distributed under the Apache License 2.0.

If you have any questions, please feel free to contact us at [email protected].
Thank you!

@kevinzakka
Copy link
Collaborator

Hi @dongridong, can you remove the stray files in the test dir?

@dongridong
Copy link
Contributor Author

Hi @dongridong, can you remove the stray files in the test dir?

Hi @kevinzakka.

As requested, I have removed all files in the test directory.
Thank you.

@kevinzakka
Copy link
Collaborator

Hi @dongridong, looks like you deleted the entire dir. I was referring to only the pycache files and additional files you had added. Can you please add back the test dir?

Also, you need to rebase your branch on top of the latest main!

@dongridong dongridong force-pushed the rainbow_robotics_rby1 branch from 45f0b6f to 03d308d Compare April 21, 2025 02:04
@dongridong
Copy link
Contributor Author

Hi @dongridong, looks like you deleted the entire dir. I was referring to only the pycache files and additional files you had added. Can you please add back the test dir?

Also, you need to rebase your branch on top of the latest main!

I've restored the test/ directory and removed only the unnecessary files.
Also, the branch has been rebased on top of the latest main.

Let me know if there's anything else you'd like me to adjust!

@dongridong
Copy link
Contributor Author

Hi @dongridong, looks like you deleted the entire dir. I was referring to only the pycache files and additional files you had added. Can you please add back the test dir?

Also, you need to rebase your branch on top of the latest main!

Hi @kevinzakka.
Would there be any additional modifications needed?

@kevinzakka
Copy link
Collaborator

Hi @dongridong, it says there are conflicts with the main branch. You need to rebase with main.

@dongridong dongridong force-pushed the rainbow_robotics_rby1 branch from 3298792 to fe8a2c2 Compare May 28, 2025 08:10
@dongridong
Copy link
Contributor Author

Hi @dongridong, it says there are conflicts with the main branch. You need to rebase with main.

Hi @kevinzakka,
I have resolved the merge conflict issues, optimized the mesh files for size, and fixed the path problems.
Please review it once more and let me know if everything looks good.

Thank you.

@kevinzakka
Copy link
Collaborator

Hi @dongridong, I’ll take a look this week!

Comment on lines +149 to +150
<geom mesh="LINK_2_0" class="collision"/>
<geom mesh="LINK_2_1" class="collision"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<geom mesh="LINK_2_0" class="collision"/>
<geom mesh="LINK_2_1" class="collision"/>
<geom mesh="LINK_2_0" class="in-model-collision"/>
<geom mesh="LINK_2_1" class="in-model-collision"/>

Without marking this as an in-model collision, the robot ends up yeeting itself and smashing into the ground. After this change, the robot is stable in its starting position.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I hope you're doing well.
I wanted to kindly follow up to ask if there are any additional modifications that need to be made.
I haven’t heard back since the last feedback, so I just wanted to check in.

Wishing you a great day!

@dongridong
Copy link
Contributor Author

dongridong commented Jun 30, 2025 via email

@dongridong
Copy link
Contributor Author

Hi @dongridong, I’ll take a look this week!

Dear @kevinzakka.

Hope you are doing well.
I have incorporated all the requested revisions.

I would appreciate it if you could review once more and update the model accordingly.

Best regards,
Ian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants