Skip to content

when only some node hasn't sync, DDL owner always print 'syncer check all versions, all nodes are not synced' #58480

@D3Hunter

Description

@D3Hunter

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

because in here, we return false directly on length mismatch, so we don't know who is unmatched

if len(nodeVersions) < len(updatedMap) {
return false
}

and cause this always enter the else branch
if id := unmatchedNodeID.Load(); id != nil {
logutil.DDLLogger().Info("syncer check all versions, someone is not synced",
zap.String("info", *id),
zap.Int64("ddl job id", jobID),
zap.Int64("ver", latestVer))
} else {
logutil.DDLLogger().Info("syncer check all versions, all nodes are not synced",
zap.Int64("ddl job id", jobID),
zap.Int64("ver", latestVer))
}

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

Metadata

Metadata

Assignees

Labels

affects-8.5This bug affects the 8.5.x(LTS) versions.component/ddlThis issue is related to DDL of TiDB.severity/minortype/bugThe issue is confirmed as a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions