-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: fix version syncer doesn't print who hasn't synced on partial sync #58511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58511 +/- ##
================================================
+ Coverage 73.5697% 75.1026% +1.5328%
================================================
Files 1681 1726 +45
Lines 464249 473865 +9616
================================================
+ Hits 341547 355885 +14338
+ Misses 101876 95696 -6180
- Partials 20826 22284 +1458
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #58480
Problem Summary:
What changed and how does it work?
Check List
Tests
tiup playground
; add sleep(5 seconds) on domain reload, and then start a tidb with this PR. runcreate table
before
after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.