DDL Notifier: Incorrect time value: '{1970 1 1 0 0 1 0}

[0xPoe]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

drop table if exists tdv;
create table tdv(a int);
ALTER TABLE tdv ADD COLUMN ts timestamp DEFAULT '1970-01-01 08:00:01';
drop table if exists tdv;

2. What did you expect to see? (Required)

DDL Notifier has no errors.

3. What did you see instead (Required)

It print out this error: Incorrect time value: '{1970 1 1 0 0 1 0}

4. What is your TiDB version? (Required)

master

[0xPoe]

Error from here:

tidb/pkg/statistics/handle/storage/save.go

Line 439 in 3cbd827

value, err = value.ConvertTo(sctx.GetSessionVars().StmtCtx.TypeCtx(), &colInfo.FieldType)

[winoros]

We can also add a test case for the case using zero datetime as default value.

[0xPoe]

The check has failed here:

tidb/pkg/types/time.go

Line 2164 in 0d74a99

func checkTimestampType(t CoreTime, tz *gotime.Location) error {

[0xPoe]

The check has failed here:

tidb/pkg/types/time.go

Line 2180 in 0d74a99

if compareTime(checkTime, MaxTimestamp.coreTime) > 0 || compareTime(checkTime, MinTimestamp.coreTime) < 0 {

[0xPoe]

The check has failed here:

tidb/pkg/types/time.go

Line 2180 in 0d74a99

if compareTime(checkTime, MaxTimestamp.coreTime) > 0 || compareTime(checkTime, MinTimestamp.coreTime) < 0 {

In this function, we convert 1970-01-01 08:00:01 to an invalid value, which is less than 1970-01-01 00:00:00.