Skip to content

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Apr 8, 2025

What problem does this PR solve?

Issue Number: close #60194

Problem Summary:

What changed and how does it work?

Fix the issue that the HandleDDLEvent cannot handle timezone issues properly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@YangKeao YangKeao requested review from Defined2014 and 0xPoe April 8, 2025 09:52
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2025
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

Copy link

ti-chi-bot bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 8, 2025
Copy link

ti-chi-bot bot commented Apr 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-08 10:00:52.561212248 +0000 UTC m=+2164146.245448345: ☑️ agreed by Defined2014.
  • 2025-04-08 10:10:14.12586271 +0000 UTC m=+2164707.810098790: ☑️ agreed by Rustin170506.

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7796%. Comparing base (1cd3943) to head (af4cca7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60438        +/-   ##
================================================
+ Coverage   73.1105%   73.7796%   +0.6691%     
================================================
  Files          1711       1741        +30     
  Lines        473248     483704     +10456     
================================================
+ Hits         345994     356875     +10881     
+ Misses       105966     104784      -1182     
- Partials      21288      22045       +757     
Flag Coverage Δ
integration 45.7428% <100.0000%> (?)
unit 72.3278% <100.0000%> (-0.0023%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6553% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2229% <ø> (-0.0139%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit fe3f47b into pingcap:master Apr 9, 2025
25 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #60439.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDL Notifier: Incorrect time value: '{1970 1 1 0 0 1 0}
4 participants