Skip to content

statistics: change default value of tidb_analyze_version to 1 #31826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 10, 2022
Merged

statistics: change default value of tidb_analyze_version to 1 #31826

merged 24 commits into from
Feb 10, 2022

Conversation

yiwen92
Copy link
Contributor

@yiwen92 yiwen92 commented Jan 19, 2022

What problem does this PR solve?

Issue Number: close #31748

Problem Summary:

What is changed and how it works?

Set the default value for tidb_analyze_version to 1 to avoid OOM issues, because this was an experimental feature in v5.1 and v5.2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Set default value of tidb_analyze_version to 1 in v5.1 and v5.2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2022
@bb7133
Copy link
Member

bb7133 commented Feb 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4e3c585

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 9, 2022
@bb7133
Copy link
Member

bb7133 commented Feb 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e7a5600

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2022
@yiwen92
Copy link
Contributor Author

yiwen92 commented Feb 10, 2022

I found FAIL in statistics test, tried several times but still not PASS, then ask @winoros to address this problem now.

@bb7133
Copy link
Member

bb7133 commented Feb 10, 2022

@winoros Please fix the test case

@hawkingrei
Copy link
Member

/run-check_dev

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2022
@winoros
Copy link
Member

winoros commented Feb 10, 2022

/run-check_dev

@bb7133
Copy link
Member

bb7133 commented Feb 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 271e4c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2022
@ti-chi-bot ti-chi-bot merged commit 094b3e5 into pingcap:release-5.1 Feb 10, 2022
@yiwen92
Copy link
Contributor Author

yiwen92 commented Feb 10, 2022

/cherry-pick release-5.2

@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 10, 2022
@yiwen92
Copy link
Contributor Author

yiwen92 commented Feb 15, 2022

Also add doc modification for this tidb_analyze_version system variable in pingcap/docs#7569 and pingcap/docs-cn#8364

yiwen92 added a commit to yiwen92/tidb that referenced this pull request Apr 9, 2022
@yiwen92
statistics: change default value of tidb_analyze_version to 1 (pingca…
7c2b51c 
…p#31826)

close pingcap#31748
@yiwen92 yiwen92 mentioned this pull request Apr 9, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2022
@yiwen92
statistics: change default value of tidb_analyze_version to 1 (#31826) (
50e35e6 
#33841)

close #31748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@yiwen92 @ti-chi-bot @bb7133 @hawkingrei @winoros @VelocityLight @zhouqiang-cl