Skip to content

statistics: change default value of tidb_analyze_version to 1 (#31826) #33841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 13, 2022
Merged

statistics: change default value of tidb_analyze_version to 1 (#31826) #33841

merged 8 commits into from
Apr 13, 2022

Conversation

yiwen92
Copy link
Contributor

@yiwen92 yiwen92 commented Apr 9, 2022 •
edited
Loading

close #31748

Cherry pick from #31826 to v5.2

What problem does this PR solve?
Issue Number: close #31748

Problem Summary:

What is changed and how it works?
Set the default value for tidb_analyze_version to 1 to avoid OOM issues, because this was an experimental feature in v5.1 and v5.2

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Change the default value of tidb_analyze_version from 2 to 1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2022
@yiwen92
Copy link
Contributor Author

yiwen92 commented Apr 12, 2022

/rerun

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ab33ce4b42dbce2878be62c7757bd545e33ffa48

@yiwen92
Copy link
Contributor Author

yiwen92 commented Apr 12, 2022

/cc @bb7133

@ti-chi-bot ti-chi-bot requested a review from bb7133 April 12, 2022 12:40
@yiwen92
Copy link
Contributor Author

yiwen92 commented Apr 13, 2022

related docs updated in pingcap/docs-cn#8551

bb7133
bb7133 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022
@bb7133
Copy link
Member

bb7133 commented Apr 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a09f351

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@yiwen92
Copy link
Contributor Author

yiwen92 commented Apr 13, 2022

/run-unit-test

1 similar comment
@yiwen92
Copy link
Contributor Author

yiwen92 commented Apr 13, 2022

/run-unit-test

@yiwen92
Copy link
Contributor Author

yiwen92 commented Apr 13, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 50e35e6 into pingcap:release-5.2 Apr 13, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 14, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Apr 18, 2022
@zhouqiang-cl zhouqiang-cl added this to the v5.2.4 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
7 participants
@yiwen92 @ti-chi-bot @sre-bot @bb7133 @winoros @VelocityLight @zhouqiang-cl