gomod: fix MinSafeTS might be set to MaxUint64 permanently #47469

HuSharp · 2023-10-09T03:23:12Z

Signed-off-by: husharp [email protected]<!--

Thank you for contributing to TiDB!

PR Title Format:

pkg [, pkg2, pkg3]: what's changed
*: what's changed

-->

What problem does this PR solve?

Issue Number: close #47468

Problem Summary:

What is changed and how it works?

The core question is getting safe ts in client-go

we introduce PD API to not execute go func which for KV request, resulting in not updating safeTSMap.
- updateMinSafeTS relies on safeTSMap which makes sense(because actually, we can call updateMinSafeTS to kvReuqestUpdater[to indicate func base]).
And we need to update minsafeTS to make sure when API fails we can fall back to the original way which is by kv request.
But the core problem is: updateMinSafeTS will return maxUnit64 when the first kv request returns 0 and then although PD API returns correctly[maybe kv is not initialized], TS can not change maxUnit64.
- to resolve this question, we need to regard maxUnit64 as 0 which means there is an initial state.

Check List

Tests

Manual test (add detailed scripts or steps below)
Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: husharp <[email protected]>

tiprow · 2023-10-09T03:23:33Z

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HuSharp · 2023-10-09T03:33:51Z

/check-issue-triage-complete

codecov · 2023-10-09T03:34:08Z

Codecov Report

Merging #47469 (37fe141) into master (c8a2112) will increase coverage by 1.1130%.
Report is 33 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47469        +/-   ##
================================================
+ Coverage   72.1409%   73.2540%   +1.1130%     
================================================
  Files          1352       1377        +25     
  Lines        401090     413348     +12258     
================================================
+ Hits         289350     302794     +13444     
+ Misses        92498      91672       -826     
+ Partials      19242      18882       -360

Flag	Coverage Δ
integration	`40.9330% <ø> (?)`
unit	`72.5883% <ø> (+0.4473%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`84.7513% <ø> (+0.0939%)`	⬆️
br	`48.9292% <ø> (-4.2775%)`	⬇️

hawkingrei · 2023-10-09T03:38:37Z

/ok-to-test

HuSharp · 2023-10-09T09:58:58Z

/test tiprow_fast_test

ti-chi-bot · 2023-10-09T09:59:01Z

@HuSharp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-prisma-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HuSharp · 2023-10-09T09:59:13Z

/test

ti-chi-bot · 2023-10-09T09:59:16Z

@HuSharp: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-prisma-test
/test pull-mysql-client-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-10-09T09:59:43Z

@HuSharp: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nolouch

lgtm

ti-chi-bot · 2023-10-11T04:19:24Z

[LGTM Timeline notifier]

Timeline:

2023-10-11 03:19:49.580612858 +0000 UTC m=+1195187.167722988: ☑️ agreed by nolouch.
2023-10-11 04:19:23.187271597 +0000 UTC m=+1198760.774381727: ☑️ agreed by JmPotato.

ti-chi-bot · 2023-10-11T05:35:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

HuSharp · 2023-10-11T06:14:19Z

/retest-required

HuSharp · 2023-10-11T07:19:11Z

/retest

HuSharp · 2023-10-11T08:32:09Z

/retest

HuSharp · 2023-10-11T09:33:09Z

/retest-required

ti-chi-bot · 2023-10-11T09:46:13Z

In response to a cherrypick label: new pull request created to branch release-6.5: #47554.

ti-chi-bot · 2023-10-11T09:46:57Z

In response to a cherrypick label: new pull request created to branch release-7.1: #47555.

…47555) close #47468

updat clientgo

37fe141

Signed-off-by: husharp <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2023

ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Oct 9, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 9, 2023

nolouch approved these changes Oct 11, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 11, 2023

JmPotato approved these changes Oct 11, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2023

tangenta approved these changes Oct 11, 2023

View reviewed changes

ti-chi-bot bot added the approved label Oct 11, 2023

ti-chi-bot bot merged commit 533c4df into pingcap:master Oct 11, 2023

ti-chi-bot mentioned this pull request Oct 11, 2023

gomod: fix MinSafeTS might be set to MaxUint64 permanently (#47469) #47554

Closed

1 task

ti-chi-bot mentioned this pull request Oct 11, 2023

gomod: fix MinSafeTS might be set to MaxUint64 permanently (#47469) #47555

Merged

1 task

ti-chi-bot bot pushed a commit that referenced this pull request Oct 12, 2023

gomod: fix MinSafeTS might be set to MaxUint64 permanently (#47469) (#…

0d9903c

…47555) close #47468

gomod: fix MinSafeTS might be set to MaxUint64 permanently #47469

gomod: fix MinSafeTS might be set to MaxUint64 permanently #47469

Uh oh!

Conversation

HuSharp commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

tiprow bot commented Oct 9, 2023

Uh oh!

HuSharp commented Oct 9, 2023

Uh oh!

codecov bot commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hawkingrei commented Oct 9, 2023

Uh oh!

HuSharp commented Oct 9, 2023

Uh oh!

ti-chi-bot bot commented Oct 9, 2023

Uh oh!

HuSharp commented Oct 9, 2023

Uh oh!

ti-chi-bot bot commented Oct 9, 2023

Uh oh!

tiprow bot commented Oct 9, 2023

Uh oh!

nolouch left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Oct 11, 2023

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot bot commented Oct 11, 2023

Uh oh!

HuSharp commented Oct 11, 2023

Uh oh!

HuSharp commented Oct 11, 2023

Uh oh!

HuSharp commented Oct 11, 2023

Uh oh!

HuSharp commented Oct 11, 2023

Uh oh!

ti-chi-bot commented Oct 11, 2023

Uh oh!

ti-chi-bot commented Oct 11, 2023

Uh oh!

Uh oh!

HuSharp commented Oct 9, 2023 •

edited

Loading

codecov bot commented Oct 9, 2023 •

edited

Loading