gomod: fix MinSafeTS might be set to MaxUint64 permanently (#47469) #47555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
ok-to-test
2 tasks
Signed-off-by: husharp <[email protected]>
HuSharp
force-pushed
the
cherry-pick-47469-to-release-7.1
branch
from
f5e4e4e to
96ca5ac
Compare
ti-chi-bot
added
the
cherry-pick-approved
HuSharp
reviewed
Oct 11, 2023
| @@ -94,7 +94,7 @@ require ( | |||
| github.com/stretchr/testify v1.8.2 | |||
| github.com/tdakkota/asciicheck v0.2.0 | |||
| github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2 | |||
| github.com/tikv/client-go/v2 v2.0.8-0.20230918072237-01087502b780 | |||
There was a problem hiding this comment.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #47555 +/- ##
================================================
Coverage ? 73.4273%
================================================
Files ? 1205
Lines ? 377072
Branches ? 0
================================================
Hits ? 276874
Misses ? 82525
Partials ? 17673 |
JmPotato
approved these changes
Oct 12, 2023
nolouch
approved these changes
Oct 12, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
tangenta
approved these changes
Oct 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, nolouch, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #47469
Signed-off-by: husharp [email protected]<!--
Thank you for contributing to TiDB!
PR Title Format:
-->
What problem does this PR solve?
Issue Number: close #47468
Problem Summary:
What is changed and how it works?
The core question is getting safe ts in client-go
PD APIto not executego func which for KV request, resulting in not updatingsafeTSMap.updateMinSafeTSrelies onsafeTSMapwhich makes sense(because actually, we can callupdateMinSafeTStokvReuqestUpdater[to indicate func base]).minsafeTSto make sure when API fails we can fall back to the original way which is by kv request.updateMinSafeTSwill returnmaxUnit64when the first kv request returns 0 and then althoughPD APIreturns correctly[maybe kv is not initialized], TS can not changemaxUnit64.maxUnit64as 0 which means there is an initial state.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.