-
Notifications
You must be signed in to change notification settings - Fork 6k
telemetry: remove the codes of Telemetry #51202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
554f933
to
35851a4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51202 +/- ##
=================================================
- Coverage 70.5887% 55.1393% -15.4495%
=================================================
Files 1467 1577 +110
Lines 434905 607140 +172235
=================================================
+ Hits 306994 334773 +27779
- Misses 108649 249426 +140777
- Partials 19262 22941 +3679
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a2dba24
to
4023cf2
Compare
4023cf2
to
ae44e66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
for lightning and domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
br part lgtm
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, BornChanger, easonn7, lance6716, ngaut, windtalker, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 3d1708f.
What problem does this PR solve?
Issue Number: close #49939
Problem Summary:
What changed and how does it work?
As is described.
Configuration 'enable-telemetry' and the system variable 'tidb_enable_telemetry' are kept for compatibility consideration, but they're both deprecated after this PR: the values of them are meanningless.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.