Skip to content

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Feb 20, 2024

What problem does this PR solve?

Issue Number: close #49939

Problem Summary:

What changed and how does it work?

As is described.

Configuration 'enable-telemetry' and the system variable 'tidb_enable_telemetry' are kept for compatibility consideration, but they're both deprecated after this PR: the values of them are meanningless.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Deprecate Telemetry for TiDB:
* Deprecate configuration '[enable-telemetry](https://docs.pingcap.com/tidb/stable/tidb-configuration-file#enable-telemetry-new-in-v402)' and the system variable '[tidb_enable_telemetry](https://docs.pingcap.com/tidb/stable/system-variables#tidb_enable_telemetry-new-in-v402)': the values of them are meaningless now.
* Remove all SQL syntax of Telemetry, including `ADMIN SHOW TELEMETRY` and `ADMIN RESET TELEMETRY_ID`.
* Remove `TELEMETRY` and `TELEMETRY_ID` from TiDB unreserved keywords list.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 20, 2024
@bb7133 bb7133 added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Feb 20, 2024
@bb7133 bb7133 force-pushed the bb7133/remove_telemetry branch from 554f933 to 35851a4 Compare February 20, 2024 11:13
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Merging #51202 (ae44e66) into master (4c76b12) will decrease coverage by 15.4495%.
Report is 14 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51202         +/-   ##
=================================================
- Coverage   70.5887%   55.1393%   -15.4495%     
=================================================
  Files          1467       1577        +110     
  Lines        434905     607140     +172235     
=================================================
+ Hits         306994     334773      +27779     
- Misses       108649     249426     +140777     
- Partials      19262      22941       +3679     
Flag Coverage Δ
integration 36.8545% <84.6153%> (?)
unit 70.9493% <100.0000%> (+0.5644%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.6857% <ø> (+5.8177%) ⬆️

@bb7133 bb7133 force-pushed the bb7133/remove_telemetry branch 5 times, most recently from a2dba24 to 4023cf2 Compare February 21, 2024 10:02
@bb7133 bb7133 force-pushed the bb7133/remove_telemetry branch from 4023cf2 to ae44e66 Compare February 21, 2024 10:39
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 21, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-21 22:10:14.606216407 +0000 UTC m=+481503.353839518: ☑️ agreed by ngaut.
  • 2024-02-22 03:20:23.857274189 +0000 UTC m=+500112.604897300: ☑️ agreed by windtalker.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

for lightning and domain

Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

br part lgtm

@wuhuizuo
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Benjamin2037, BornChanger, lance6716, ngaut, windtalker, zimulala Once this PR has been reviewed and has the lgtm label, please assign d3hunter, easonn7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

@bb7133 rest parts need be approved by d3hunter and easonn7

@easonn7
Copy link

easonn7 commented Feb 22, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, BornChanger, easonn7, lance6716, ngaut, windtalker, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3d1708f into pingcap:master Feb 22, 2024
@bb7133 bb7133 deleted the bb7133/remove_telemetry branch February 23, 2024 03:05
budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025
Defined2014 added a commit to Defined2014/tidb that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: remove all codes of telemetry
9 participants