-
Notifications
You must be signed in to change notification settings - Fork 6k
topsql, pprof: use hex string but not binary sql/plan digest in goroutine label #52216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52216 +/- ##
================================================
+ Coverage 70.7107% 70.7154% +0.0046%
================================================
Files 1487 1546 +59
Lines 439605 455441 +15836
================================================
+ Hits 310848 322067 +11219
- Misses 109287 113411 +4124
- Partials 19470 19963 +493
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
6a263a3
to
31a81ff
Compare
bb43e3f
to
6193ce1
Compare
/hold Wait for @crazycs520's review to confirm it'll not break the TopSQL functionality 🤔. Please unhold it when @crazycs520 thinks it's ready. |
Signed-off-by: Yang Keao <[email protected]>
6193ce1
to
f12e744
Compare
[LGTM Timeline notifier]Timeline:
|
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, hawkingrei, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherrypick release-7.5 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #52215
Problem Summary:
Use the hex string in goroutine labels. It'll allow us to use the
go tool pprof
and graphviz to handle the protobuf.Before this PR returned, you can workaround by generating a
dot
file, and useiconv
to handle the non-utf8 characters manually.What changed and how does it work?
Use the pre-ecoded hex string, rather than bytes.
Check List
Tests
Run any tests (which runs at least some SQLs) and profile it with
-cpuprofile
, and you'll find the protobuf is useable now.Release note