topsql, pprof: use hex string but not binary sql/plan digest in goroutine label (#52216) #52324
+33
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #52216
What problem does this PR solve?
Issue Number: close #52215
Problem Summary:
Use the hex string in goroutine labels. It'll allow us to use the
go tool pprof
and graphviz to handle the protobuf.Before this PR returned, you can workaround by generating a
dot
file, and useiconv
to handle the non-utf8 characters manually.What changed and how does it work?
Use the pre-ecoded hex string, rather than bytes.
Check List
Tests
Run any tests (which runs at least some SQLs) and profile it with
-cpuprofile
, and you'll find the protobuf is useable now.Release note