Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52216

What problem does this PR solve?

Issue Number: close #52215

Problem Summary:

Use the hex string in goroutine labels. It'll allow us to use the go tool pprof and graphviz to handle the protobuf.

Before this PR returned, you can workaround by generating a dot file, and use iconv to handle the non-utf8 characters manually.

What changed and how does it work?

Use the pre-ecoded hex string, rather than bytes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Run any tests (which runs at least some SQLs) and profile it with -cpuprofile, and you'll find the protobuf is useable now.

Release note

None

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 3, 2024
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@fde2234). Click here to learn what that means.
The diff coverage is 81.4814%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52324   +/-   ##
================================================
  Coverage               ?   71.9779%           
================================================
  Files                  ?       1410           
  Lines                  ?     409406           
  Branches               ?          0           
================================================
  Hits                   ?     294682           
  Misses                 ?      94892           
  Partials               ?      19832           
Flag Coverage Δ
unit 71.9779% <81.4814%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3131% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 3, 2024
@hawkingrei hawkingrei requested a review from YangKeao April 3, 2024 05:04
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 3, 2024
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 3, 2024
Copy link

ti-chi-bot bot commented Apr 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-03 05:03:50.047027941 +0000 UTC m=+420291.574568486: ☑️ agreed by hawkingrei.
  • 2024-04-03 06:12:01.842308586 +0000 UTC m=+424383.369849133: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit 9fd6e81 into pingcap:release-7.5 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants