lightning: update `parquet-go` to optimize the memory usage when importing parquet files. #53474

zeminzhou · 2024-05-22T06:34:44Z

What problem does this PR solve?

Issue Number: close #53466

Problem Summary:

What changed and how does it work?

update parquet-go for lightning

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

start tidb cluster
start lightning server
import parquet files
observer memory usage of lightning, ref Optimize the memory usage of lightning when importing parquet data format files #53466

No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: zzm <[email protected]>

tiprow · 2024-05-22T06:34:58Z

Hi @zeminzhou. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-05-22T06:50:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6996%. Comparing base (d1b8c5b) to head (4c71189).
Report is 8 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53474        +/-   ##
================================================
+ Coverage   72.5278%   74.6996%   +2.1717%     
================================================
  Files          1505       1527        +22     
  Lines        429865     438342      +8477     
================================================
+ Hits         311772     327440     +15668     
+ Misses        98812      90403      -8409     
- Partials      19281      20499      +1218

Flag	Coverage Δ
integration	`50.7550% <ø> (?)`
unit	`71.4217% <ø> (+0.0051%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9957% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`50.4300% <ø> (+9.0328%)`	⬆️

Signed-off-by: zzm <[email protected]>

zeminzhou · 2024-05-22T08:18:03Z

/test build

ti-chi-bot · 2024-05-22T08:18:06Z

@zeminzhou: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zeminzhou · 2024-05-22T08:18:16Z

/test unit-test

ti-chi-bot · 2024-05-22T08:18:19Z

@zeminzhou: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-05-22T08:18:24Z

@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-05-22T08:18:38Z

@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zeminzhou · 2024-05-22T08:18:38Z

/retest

tiprow · 2024-05-22T08:19:00Z

@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: zzm <[email protected]>

Signed-off-by: zeminzhou <[email protected]>

ti-chi-bot · 2024-05-23T02:55:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lance6716,okJiang]
~~pkg/lightning/OWNERS~~ [lance6716,okJiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-05-23T02:55:04Z

[LGTM Timeline notifier]

Timeline:

2024-05-22 08:28:50.741559165 +0000 UTC m=+2246684.498694738: ☑️ agreed by lance6716.
2024-05-23 02:55:03.458289133 +0000 UTC m=+2313057.215424706: ☑️ agreed by okJiang.

zeminzhou · 2024-05-23T03:20:57Z

/retest

tiprow · 2024-05-23T03:21:19Z

@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zeminzhou · 2024-05-23T03:21:34Z

/ok-to-test

zeminzhou · 2024-05-23T03:31:22Z

/ok-to-test

zeminzhou · 2024-05-23T03:33:52Z

/retest

zeminzhou · 2024-05-23T04:48:41Z

/retest

…rting parquet files. (pingcap#53474) close pingcap#53466

update parquet-go to optimize the memory usage of lightnnig

e779d6b

Signed-off-by: zzm <[email protected]>

ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels May 22, 2024

make check

87288fe

Signed-off-by: zzm <[email protected]>

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2024

lance6716 approved these changes May 22, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 22, 2024

zeminzhou added 2 commits May 22, 2024 16:40

fix ut

83f121b

Signed-off-by: zzm <[email protected]>

fix ut

4c71189

Signed-off-by: zeminzhou <[email protected]>

okJiang approved these changes May 23, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2024

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label May 23, 2024

ti-chi-bot bot merged commit 22dc064 into pingcap:master May 23, 2024

zeminzhou deleted the zeminzhou/update-parquet-go branch May 23, 2024 05:29

RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 27, 2024

lightning: update parquet-go to optimize the memory usage when impo…

61851c9

…rting parquet files. (pingcap#53474) close pingcap#53466

lightning: update parquet-go to optimize the memory usage when importing parquet files. #53474

lightning: update parquet-go to optimize the memory usage when importing parquet files. #53474

Uh oh!

Conversation

zeminzhou commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented May 22, 2024

Uh oh!

codecov bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zeminzhou commented May 22, 2024

Uh oh!

ti-chi-bot bot commented May 22, 2024

Uh oh!

zeminzhou commented May 22, 2024

Uh oh!

ti-chi-bot bot commented May 22, 2024

Uh oh!

tiprow bot commented May 22, 2024

Uh oh!

tiprow bot commented May 22, 2024

Uh oh!

zeminzhou commented May 22, 2024

Uh oh!

tiprow bot commented May 22, 2024

Uh oh!

ti-chi-bot bot commented May 23, 2024

Uh oh!

ti-chi-bot bot commented May 23, 2024

[LGTM Timeline notifier]

Uh oh!

zeminzhou commented May 23, 2024

Uh oh!

tiprow bot commented May 23, 2024

Uh oh!

zeminzhou commented May 23, 2024

Uh oh!

zeminzhou commented May 23, 2024

Uh oh!

zeminzhou commented May 23, 2024

Uh oh!

zeminzhou commented May 23, 2024

Uh oh!

Uh oh!

lightning: update `parquet-go` to optimize the memory usage when importing parquet files. #53474

lightning: update `parquet-go` to optimize the memory usage when importing parquet files. #53474

zeminzhou commented May 22, 2024 •

edited

Loading

codecov bot commented May 22, 2024 •

edited

Loading