statistics: not convert the database names to lowercase duration the auto analyze #53906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
hawkingrei
changed the title
|
/retest |
winoros
approved these changes
Jun 11, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53906 +/- ##
=================================================
- Coverage 74.5027% 55.8563% -18.6465%
=================================================
Files 1508 1628 +120
Lines 358349 602451 +244102
=================================================
+ Hits 266980 336507 +69527
- Misses 71944 242717 +170773
- Partials 19425 23227 +3802
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…e process Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
force-pushed
the
remove_tolower
branch
from
7490681 to
87b9d07
Compare
Signed-off-by: Weizhen Wang <[email protected]>
|
/retest |
0xPoe
approved these changes
Jun 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hi-rustin, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #53905
Problem Summary:
What changed and how does it work?
no need to convert the database names to lowercase in the analyze process. it takes some time on it.
https://flamegraph.com/share/28183024-2742-11ef-ab1b-b6898751f631
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.