Skip to content

statistics: not convert the database names to lowercase duration the auto analyze #53906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged

statistics: not convert the database names to lowercase duration the auto analyze #53906

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab20be0
statistics: not convert the database names to lowercase in the analyz…
hawkingrei Jun 10, 2024
87b9d07
*
hawkingrei Jun 11, 2024
610d649
*
hawkingrei Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions pkg/statistics/handle/autoanalyze/refresher/refresher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
package refresher

import (
"strings"
"time"

"github.com/pingcap/tidb/pkg/infoschema"
Expand Down Expand Up @@ -169,19 +168,19 @@ func (r *Refresher) RebuildTableAnalysisJobQueue() error {
return err
}

dbs := infoschema.AllSchemaNames(is)
dbs := is.AllSchemaNames()
for _, db := range dbs {
// Sometimes the tables are too many. Auto-analyze will take too much time on it.
// so we need to check the available time.
if !r.autoAnalysisTimeWindow.isWithinTimeWindow(time.Now()) {
return nil
}
// Ignore the memory and system database.
if util.IsMemOrSysDB(strings.ToLower(db)) {
if util.IsMemOrSysDB(db.L) {
continue
}

tbls := is.SchemaTables(model.NewCIStr(db))
tbls := is.SchemaTables(db)
// We need to check every partition of every table to see if it needs to be analyzed.
for _, tbl := range tbls {
// If table locked, skip analyze all partitions of the table.
Expand Down Expand Up @@ -217,7 +216,7 @@ func (r *Refresher) RebuildTableAnalysisJobQueue() error {
if pi == nil {
job := CreateTableAnalysisJob(
sctx,
db,
db.O,
tblInfo,
r.statsHandle.GetTableStatsForAutoAnalyze(tblInfo),
autoAnalyzeRatio,
Expand All @@ -241,7 +240,7 @@ func (r *Refresher) RebuildTableAnalysisJobQueue() error {
for pIDAndName, stats := range partitionStats {
job := CreateStaticPartitionAnalysisJob(
sctx,
db,
db.O,
tblInfo,
pIDAndName.ID,
pIDAndName.Name,
Expand All @@ -254,7 +253,7 @@ func (r *Refresher) RebuildTableAnalysisJobQueue() error {
} else {
job := createTableAnalysisJobForPartitions(
sctx,
db,
db.O,
tblInfo,
r.statsHandle.GetPartitionStatsForAutoAnalyze(tblInfo, tblInfo.ID),
partitionStats,
Expand Down