Skip to content

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Sep 19, 2024

What problem does this PR solve?

Issue Number: close #55837

Problem Summary:
In MySQL, it support minimum display length when creating a integer type, for example, you can create table with type col1 bigint(4), it means the display length of col1 should be at least 4.
However, TiDB just treated 4 as the flen of the current type, which will cause wrong result in some cases, since 4 here does not mean the max length of col1 is 4: for example, in #55837 a column is declared as ts bigint(4), so tidb think the result type of ts/1000 is Decimal(9,4), which is obviousely wrong, and caused the wrong result.

Since the root cause of #55837 is when user declare an interger type with minimun display length, TiDB actually treated the minimum display length as the max length of the given type, a complete fix should be re-design of TiDB's support of minimum display length of integer type, which will involve a lots of work, and it's hardly to be finished within a short time. So this pr use a simple workaround to fix #55837

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.7479%. Comparing base (c13eb90) to head (57b2491).
Report is 21 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56158         +/-   ##
=================================================
- Coverage   72.9321%   56.7479%   -16.1842%     
=================================================
  Files          1611       1736        +125     
  Lines        447557     631265     +183708     
=================================================
+ Hits         326413     358230      +31817     
- Misses       101153     249372     +148219     
- Partials      19991      23663       +3672     
Flag Coverage Δ
integration 38.2459% <100.0000%> (?)
unit 72.9667% <100.0000%> (+0.9559%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8854% <ø> (+6.9823%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 20, 2024
Copy link

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
Copy link

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 04:54:16.111982731 +0000 UTC m=+1196125.852406671: ☑️ agreed by XuHuaiyu.
  • 2024-09-20 05:38:41.980514375 +0000 UTC m=+1198791.720938317: ☑️ agreed by wshwsh12.

@ti-chi-bot ti-chi-bot bot merged commit 801e555 into pingcap:master Sep 20, 2024
23 checks passed
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56211.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56212.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
@windtalker windtalker deleted the fix_55837 branch September 23, 2024 01:33
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
winoros pushed a commit to winoros/tidb that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if(ts >9999999999, ts/1000, ts) wrong
4 participants