Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56158

What problem does this PR solve?

Issue Number: close #55837

Problem Summary:
In MySQL, it support minimum display length when creating a integer type, for example, you can create table with type col1 bigint(4), it means the display length of col1 should be at least 4.
However, TiDB just treated 4 as the flen of the current type, which will cause wrong result in some cases, since 4 here does not mean the max length of col1 is 4: for example, in #55837 a column is declared as ts bigint(4), so tidb think the result type of ts/1000 is Decimal(9,4), which is obviousely wrong, and caused the wrong result.

Since the root cause of #55837 is when user declare an interger type with minimun display length, TiDB actually treated the minimum display length as the max length of the given type, a complete fix should be re-design of TiDB's support of minimum display length of integer type, which will involve a lots of work, and it's hardly to be finished within a short time. So this pr use a simple workaround to fix #55837

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Sep 23, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@4261bf4). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #56212   +/-   ##
================================================
  Coverage               ?   71.1845%           
================================================
  Files                  ?       1466           
  Lines                  ?     423116           
  Branches               ?          0           
================================================
  Hits                   ?     301193           
  Misses                 ?     101415           
  Partials               ?      20508           
Flag Coverage Δ
unit 71.1845% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2982% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 01:36:31.036118278 +0000 UTC m=+1443460.776542217: ☑️ agreed by windtalker.
  • 2024-09-23 03:16:07.490176466 +0000 UTC m=+1449437.230600405: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot merged commit 26ee4fc into pingcap:release-8.1 Sep 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants