Skip to content

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Oct 11, 2024

What problem does this PR solve?

Issue Number: close #56549

Problem Summary:

What changed and how does it work?

  • Add isTableTiFlashSupported check
  • Unify unsupported set TiFlash replica error messages.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2024
Copy link

tiprow bot commented Oct 11, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pingcap pingcap deleted a comment from ti-chi-bot bot Oct 11, 2024
@zimulala zimulala changed the title ddl: fix a but that create table with vector index and gbk charset co… ddl: fix a bug that create table with vector index and gbk charset column Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.1982%. Comparing base (1946f92) to head (ac559e5).
Report is 23 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56585         +/-   ##
=================================================
- Coverage   73.3506%   57.1982%   -16.1525%     
=================================================
  Files          1628       1778        +150     
  Lines        449546     637682     +188136     
=================================================
+ Hits         329745     364743      +34998     
- Misses        99570     247878     +148308     
- Partials      20231      25061       +4830     
Flag Coverage Δ
integration 39.3119% <33.3333%> (?)
unit 72.7098% <100.0000%> (+0.2443%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1769% <ø> (+17.5984%) ⬆️

@zimulala
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Oct 11, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 12, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2024
@zimulala zimulala requested a review from wjhuang2016 October 12, 2024 02:56
Copy link

ti-chi-bot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2024
Copy link

ti-chi-bot bot commented Oct 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-12 02:32:44.494650292 +0000 UTC m=+65561.643560116: ☑️ agreed by Defined2014.
  • 2024-10-12 07:58:32.037804948 +0000 UTC m=+85109.186714777: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 7ce31fa into pingcap:master Oct 12, 2024
26 checks passed
@zimulala zimulala deleted the zimuxia/create-tbl-vector branch October 14, 2024 02:10
@zimulala zimulala added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #56637.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 14, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid collation ID using vector
4 participants