Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56585

What problem does this PR solve?

Issue Number: close #56549

Problem Summary:

What changed and how does it work?

  • Add isTableTiFlashSupported check
  • Unify unsupported set TiFlash replica error messages.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Oct 14, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.4@5e933ba). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #56637   +/-   ##
================================================
  Coverage               ?   56.2268%           
================================================
  Files                  ?       1751           
  Lines                  ?     628054           
  Branches               ?          0           
================================================
  Hits                   ?     353135           
  Misses                 ?     251027           
  Partials               ?      23892           
Flag Coverage Δ
integration 36.8197% <33.3333%> (?)
unit 72.4824% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3316% <0.0000%> (?)

@zimulala
Copy link
Contributor

/test check-dev

Copy link

tiprow bot commented Oct 14, 2024

@zimulala: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zimulala zimulala requested a review from wjhuang2016 October 14, 2024 09:17
@pingcap pingcap deleted a comment from ti-chi-bot bot Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-14 08:42:30.112141379 +0000 UTC m=+260547.261051203: ☑️ agreed by Defined2014.
  • 2024-10-14 09:18:44.390231993 +0000 UTC m=+262721.539141825: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit e316107 into pingcap:release-8.4 Oct 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants