-
Notifications
You must be signed in to change notification settings - Fork 6k
statistics: fix bad lower bound and upper bound when to dump stats into json #57314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57314 +/- ##
================================================
+ Coverage 72.8973% 73.7383% +0.8409%
================================================
Files 1672 1702 +30
Lines 461745 470122 +8377
================================================
+ Hits 336600 346660 +10060
+ Misses 104426 102140 -2286
- Partials 20719 21322 +603
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
97b8260
to
cf3a834
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/hold |
Signed-off-by: Weizhen Wang <[email protected]>
/unhold |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56083
Problem Summary:
What changed and how does it work?
We will reuse the memory when to create stats. so we need to copy memory into
JsonTbl
. but we forget to copy.so it lead to break lower bound and upper bound.pkg/statistics/handle/storage/json.go:91 (it will try to reuse the memory)-> GenJSONTableFromStats -> dumpJSONCol -> HistogramToProto (it forget to copy it)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.