Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57314

What problem does this PR solve?

Issue Number: close #56083

Problem Summary:

What changed and how does it work?

We will reuse the memory when to create stats. so we need to copy memory into JsonTbl. but we forget to copy.so it lead to break lower bound and upper bound.

pkg/statistics/handle/storage/json.go:91 (it will try to reuse the memory)-> GenJSONTableFromStats -> dumpJSONCol -> HistogramToProto (it forget to copy it)

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

 fix bad lower bound and upper bound when to dump stats into json

修复在dump stats转json过程中,导致 hist 上下界数据受损的问题 

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 14, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@fc8b225). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57363   +/-   ##
================================================
  Coverage               ?   56.4379%           
================================================
  Files                  ?       1780           
  Lines                  ?     635503           
  Branches               ?          0           
================================================
  Hits                   ?     358665           
  Misses                 ?     252686           
  Partials               ?      24152           
Flag Coverage Δ
integration 37.2563% <100.0000%> (?)
unit 72.6255% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.5919% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
Copy link

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 01:39:50.503052012 +0000 UTC m=+493152.693921002: ☑️ agreed by hawkingrei.
  • 2024-11-14 01:54:08.722217471 +0000 UTC m=+494010.913086466: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 0db50c1 into pingcap:release-8.5 Nov 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants