ddl: fix job state overridden when concurrent updates don't overlap in time range

[D3Hunter]

What problem does this PR solve?

Issue Number: close #52747

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 83.07692% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.7750%. Comparing base (985609a) to head (bc9d418).
Report is 350 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58495        +/-   ##
================================================
+ Coverage   73.5432%   74.7750%   +1.2317%     
================================================
  Files          1681       1726        +45     
  Lines        463983     477570     +13587     
================================================
+ Hits         341228     357103     +15875     
+ Misses       101937      98172      -3765     
- Partials      20818      22295      +1477     

Flag	Coverage Δ
integration	49.1863% <74.0740%> (?)
unit	72.4371% <83.0769%> (+0.1327%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	60.8378% <ø> (+15.0934%)	⬆️

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

not sure what's the duration of comparing two 6M bytes.

[D3Hunter]

worst case, about 210us

goos: darwin
goarch: arm64
pkg: try-out/test/misc
cpu: Apple M1
BenchmarkCompareBytes-8   	    6459	    211581 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	try-out/test/misc	1.408s

func BenchmarkCompareBytes(b *testing.B) {
	size := 6 << 20
	l := make([]byte, 0, size)
	for i := 0; i < size; i++ {
		l = append(l, 'a')
	}
	r := make([]byte, 0, size)
	for i := 0; i < size; i++ {
		r = append(r, 'a')
	}

	b.ResetTimer()
	for i := 0; i < b.N; i++ {
		_ = bytes.Equal(l, r)
	}
}

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance6716,wjhuang2016]
• pkg/ddl/OWNERS [lance6716,wjhuang2016]
• pkg/meta/OWNERS [lance6716,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-24 07:47:56.897892089 +0000 UTC m=+1547866.986694631: ☑️ agreed by wjhuang2016.
• 2024-12-25 05:54:06.573193607 +0000 UTC m=+1627436.661996147: ☑️ agreed by lance6716.

[tiprow]

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	bc9d418	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #58755.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #59728.
But this PR has conflicts, please resolve them!