-
Notifications
You must be signed in to change notification settings - Fork 6k
ttl: don't GC running TTL jobs #58644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58644 +/- ##
================================================
+ Coverage 73.0444% 73.6724% +0.6280%
================================================
Files 1690 1690
Lines 467068 468373 +1305
================================================
+ Hits 341167 345062 +3895
+ Misses 104921 102442 -2479
+ Partials 20980 20869 -111
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
Issue Number: close #58642
Problem Summary:
What changed and how does it work?
As mentioned in #58539, a better solution to #58510 is to not remove running TTL jobs in GC, but let the owner to finish the job.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.