Skip to content

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jan 2, 2025

What problem does this PR solve?

Issue Number: close #58642

Problem Summary:

What changed and how does it work?

As mentioned in #58539, a better solution to #58510 is to not remove running TTL jobs in GC, but let the owner to finish the job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2025
@YangKeao YangKeao changed the title ttl: dont GC running TTL jobs ttl: don't GC running TTL jobs Jan 2, 2025
@YangKeao YangKeao requested review from lcwangchao and bb7133 January 2, 2025 02:27
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 84.50704% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.6724%. Comparing base (a790f86) to head (b268316).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58644        +/-   ##
================================================
+ Coverage   73.0444%   73.6724%   +0.6280%     
================================================
  Files          1690       1690                
  Lines        467068     468373      +1305     
================================================
+ Hits         341167     345062      +3895     
+ Misses       104921     102442      -2479     
+ Partials      20980      20869       -111     
Flag Coverage Δ
integration 43.0031% <2.8169%> (?)
unit 72.4479% <84.5070%> (+0.2190%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.5431% <ø> (+0.0114%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2025
@YangKeao YangKeao requested review from Defined2014 and removed request for bb7133 February 11, 2025 04:09
Signed-off-by: Yang Keao <[email protected]>
Copy link

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
Copy link

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-02 03:23:04.109481194 +0000 UTC m=+579919.465485738: ☑️ agreed by lcwangchao.
  • 2025-02-11 04:50:51.855649597 +0000 UTC m=+332094.251871659: ☑️ agreed by Defined2014.

@lcwangchao
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot merged commit 01a52cb into pingcap:master Feb 11, 2025
24 checks passed
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't GC row in tidb_ttl_table_status if the current status is running
3 participants