Skip to content

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Feb 20, 2025

What problem does this PR solve?

Issue Number: close #59723

Problem Summary:

What changed and how does it work?

we detect partition changes during log restore, if we found a partition is moved in/out of the filter range during log restore, we throw an error since we cannot support on partition level right now. If the partition exchange happens totally in or out of the filter range without moving across the filter boundary, we can support that and no error will be thrown.

also added a few more tests to piggyback on this PR

  1. filter restore one table at a time and don't clean up cluster
  2. filter restore with log compaction
  3. filter restore with truncation

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Wenqi Mou <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2025
@Tristan1900 Tristan1900 changed the title br: error out if pitr table filter has exchange partition in/out filter range br: error out if pit with table filter has exchange partition in/out filter range Feb 20, 2025
Copy link

tiprow bot commented Feb 20, 2025

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 76.71233% with 17 lines in your changes missing coverage. Please review.

Project coverage is 74.6095%. Comparing base (0fc1412) to head (c200350).
Report is 45 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59683        +/-   ##
================================================
+ Coverage   72.9943%   74.6095%   +1.6152%     
================================================
  Files          1697       1715        +18     
  Lines        468905     475947      +7042     
================================================
+ Hits         342274     355102     +12828     
+ Misses       105552      98817      -6735     
- Partials      21079      22028       +949     
Flag Coverage Δ
integration 46.3537% <76.7123%> (?)
unit 72.1501% <0.0000%> (-0.0522%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.9449% <76.7123%> (+15.8430%) ⬆️

@Tristan1900 Tristan1900 changed the title br: error out if pit with table filter has exchange partition in/out filter range br: error out if pitr with table filter has exchange partition in/out filter range Feb 21, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2025
@Tristan1900
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 24, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 25, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 25, 2025
@Tristan1900
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 25, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Wenqi Mou <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2025
Copy link

ti-chi-bot bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2025
Copy link

ti-chi-bot bot commented Feb 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-28 07:14:48.41912308 +0000 UTC m=+599236.372281345: ☑️ agreed by Leavrth.
  • 2025-02-28 08:30:57.373347278 +0000 UTC m=+603805.326505543: ☑️ agreed by BornChanger.

@BornChanger
Copy link
Contributor

/test pull-br-integration-test

Copy link

tiprow bot commented Feb 28, 2025

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BornChanger
Copy link
Contributor

/run tidb-parser-test

Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900
Copy link
Contributor Author

/hold
until test pass

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 28, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 28, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 28, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2025
@ti-chi-bot ti-chi-bot bot merged commit c2588e1 into pingcap:master Mar 1, 2025
23 checks passed
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Jun 4, 2025
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: error out when exchange partition in/out filter range during pitr restore
3 participants