Skip to content

planner: fix wrong extend predicate simplification for subquery and nested expressions #59922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 10, 2025
Merged

planner: fix wrong extend predicate simplification for subquery and nested expressions #59922

merged 12 commits into from
Mar 10, 2025

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 5, 2025 •
edited
Loading

…

What problem does this PR solve?

Issue Number: close #58509

close #58451

Problem Summary:

What changed and how does it work?

we will remove some schema info when extending predicate simplification for subqueries and nested expressions. but Those schema info are important and is used in the GroupBy.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.5426%. Comparing base (f8f667e) to head (a473275).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59922        +/-   ##
================================================
+ Coverage   73.1004%   73.5426%   +0.4422%     
================================================
  Files          1702       1702                
  Lines        470101     470157        +56     
================================================
+ Hits         343646     345766      +2120     
+ Misses       105301     103211      -2090     
- Partials      21154      21180        +26
Flag Coverage Δ
integration 42.7134% <86.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2199% <ø> (+0.0194%) ⬆️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei changed the title planner: fix wrong extend predicate simplification for subquery and nested expressions planner: fix wrong extend predicate simplification for subquery and nested expressions | tidb-test=pr/2494 Mar 6, 2025
@hawkingrei
Copy link
Member Author

/retest

AilinKid
AilinKid approved these changes Mar 6, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2025
@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2025
windtalker
windtalker approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-06 08:13:05.287144688 +0000 UTC m=+515698.416064431: ☑️ agreed by AilinKid.
  • 2025-03-07 06:46:03.178385974 +0000 UTC m=+596876.307305719: ☑️ agreed by windtalker.

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei changed the title planner: fix wrong extend predicate simplification for subquery and nested expressions | tidb-test=pr/2494 planner: keep schema when to extend predicate simplification for subquery and nested expressions | tidb-test=pr/2494 Mar 10, 2025
@hawkingrei hawkingrei changed the title planner: keep schema when to extend predicate simplification for subquery and nested expressions | tidb-test=pr/2494 planner: keep schema when to extend predicate simplification for subquery and nested expressions Mar 10, 2025
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
planner: fix wrong extend predicate simplification for subquery and n…
8940f7e 
…ested expressions

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
71e8c51 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
1663d76 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
763e464 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
5a08608 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
6d0f6f4 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei changed the title planner: keep schema when to extend predicate simplification for subquery and nested expressions planner: fix wrong extend predicate simplification for subquery and nested expressions Mar 10, 2025
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
update
699b2d9 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
ba433fb 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
393c438 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2025
@hawkingrei
update
38fa8d9 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
0df31e3 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, windtalker, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
update
a473275 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2025
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit c902ad1 into pingcap:master Mar 10, 2025
24 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-9.0-beta.1

@ti-chi-bot
Copy link
Member

@hawkingrei: failed to apply #59922 on top of branch "release-9.0-beta.1":

failed to git commit: exit status 1

In response to this:

/cherrypick release-9.0-beta.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member Author

/cherrypick release-9.0

@ti-chi-bot
Copy link
Member

@hawkingrei: cannot checkout release-9.0: error checking out release-9.0: exit status 1. output: error: pathspec 'release-9.0' did not match any file(s) known to git

In response to this:

/cherrypick release-9.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@hawkingrei @zeminzhou
planner: fix wrong extend predicate simplification for subquery and n…
43d417b 
…ested expressions (pingcap#59922)

close pingcap#58509
winoros pushed a commit to winoros/tidb that referenced this pull request Jun 11, 2025
@hawkingrei @winoros
planner: fix wrong extend predicate simplification for subquery and n…
e99d482 
…ested expressions (pingcap#59922)

close pingcap#58509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@winoros winoros winoros approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tikv cop test failed after PR 58261 due to unexpected result. TiFlash daily test failed after PR 58261 due to resolveColumnIndex failure
5 participants
@hawkingrei @ti-chi-bot @windtalker @winoros @AilinKid