Skip to content

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Apr 1, 2025

What problem does this PR solve?

Issue Number: close #59279

Problem Summary:

This PR upgrades client-go to use the log redact feature in tikv/client-go#1612.

What changed and how does it work?

NA

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2025
Copy link

tiprow bot commented Apr 1, 2025

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -85,7 +85,7 @@ require (
github.com/otiai10/copy v1.14.0
Copy link
Member

@hawkingrei hawkingrei Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make bazel_prepare.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6209%. Comparing base (c9b33d6) to head (674895b).
Report is 522 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60353        +/-   ##
================================================
+ Coverage   73.0908%   73.6209%   +0.5300%     
================================================
  Files          1714       1714                
  Lines        474865     475252       +387     
================================================
+ Hits         347083     349885      +2802     
+ Misses       106433     104078      -2355     
+ Partials      21349      21289        -60     
Flag Coverage Δ
integration 42.7135% <ø> (?)
unit 72.4549% <ø> (+0.1527%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6553% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2934% <ø> (+0.0193%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tangenta tangenta force-pushed the client-go-redact-log branch from 0a9a829 to 7d26c34 Compare April 2, 2025 13:58
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2025
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Apr 3, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 12, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2025
@ti-chi-bot ti-chi-bot bot removed the approved label Apr 15, 2025
@tangenta
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Apr 15, 2025
Copy link

ti-chi-bot bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2025
Copy link

ti-chi-bot bot commented Apr 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-15 04:47:38.654002636 +0000 UTC m=+2750152.338238732: ☑️ agreed by Defined2014.
  • 2025-04-15 05:46:24.535709006 +0000 UTC m=+2753678.219945104: ☑️ agreed by hawkingrei.

@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6ec0bd2 into pingcap:master Apr 15, 2025
24 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 15, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #60578.
But this PR has conflicts, please resolve them!

tangenta added a commit to ti-chi-bot/tidb that referenced this pull request Apr 17, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 8, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 8, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #62278.
But this PR has conflicts, please resolve them!

tangenta added a commit to ti-chi-bot/tidb that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidb log redaction leaks raw keys to logs
4 participants