-
Notifications
You must be signed in to change notification settings - Fork 6k
go.mod: upgrade client-go to support redact log #60353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -85,7 +85,7 @@ require ( | |||
github.com/otiai10/copy v1.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make bazel_prepare
.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60353 +/- ##
================================================
+ Coverage 73.0908% 73.6209% +0.5300%
================================================
Files 1714 1714
Lines 474865 475252 +387
================================================
+ Hits 347083 349885 +2802
+ Misses 106433 104078 -2355
+ Partials 21349 21289 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: tangenta <[email protected]>
Signed-off-by: tangenta <[email protected]>
0a9a829
to
7d26c34
Compare
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: tangenta <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: tangenta <[email protected]>
What problem does this PR solve?
Issue Number: close #59279
Problem Summary:
This PR upgrades client-go to use the log redact feature in tikv/client-go#1612.
What changed and how does it work?
NA
Check List
Tests
See support redact key in logs tikv/client-go#1612 (comment)
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.