Skip to content

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Apr 2, 2025

What problem does this PR solve?

Issue Number: close #60361

Problem Summary:

What changed and how does it work?

disable switch to import mode when using global sort, no change for local sort

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2025
Copy link

tiprow bot commented Apr 2, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6838%. Comparing base (be7ebdb) to head (80b8502).
Report is 507 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60363        +/-   ##
================================================
+ Coverage   73.1542%   73.6838%   +0.5296%     
================================================
  Files          1710       1710                
  Lines        472797     473785       +988     
================================================
+ Hits         345871     349103      +3232     
+ Misses       105675     103495      -2180     
+ Partials      21251      21187        -64     
Flag Coverage Δ
integration 42.9833% <0.0000%> (?)
unit 72.4986% <100.0000%> (+0.1358%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2451% <ø> (+0.0416%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 2, 2025

/retest

Copy link

tiprow bot commented Apr 2, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 2, 2025

/retest

Copy link

tiprow bot commented Apr 2, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 2, 2025

/retest

Copy link

tiprow bot commented Apr 2, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2025
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2025
Copy link

ti-chi-bot bot commented Apr 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-02 08:20:09.635515026 +0000 UTC m=+1639703.319751122: ☑️ agreed by Benjamin2037.
  • 2025-04-02 08:24:06.217242907 +0000 UTC m=+1639939.901479002: ☑️ agreed by GMHDBJD.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 2, 2025

/cherry-pick feature/release-8.1-gsort-test

@ti-chi-bot
Copy link
Member

@D3Hunter: once the present PR merges, I will cherry-pick it on top of feature/release-8.1-gsort-test in the new PR and assign it to you.

In response to this:

/cherry-pick feature/release-8.1-gsort-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Apr 2, 2025

/retest

Copy link

tiprow bot commented Apr 2, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit fe5a517 into pingcap:master Apr 2, 2025
24 checks passed
@D3Hunter D3Hunter deleted the disable-i-mode branch April 2, 2025 11:01
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 2, 2025
@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch feature/release-8.1-gsort-test: #60379.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick feature/release-8.1-gsort-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzzf678 fzzf678 added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 26, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #62027.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #62028.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable 'import-mode' when using global sort
5 participants