Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #60363

What problem does this PR solve?

Issue Number: close #60361

Problem Summary:

What changed and how does it work?

disable switch to import mode when using global sort, no change for local sort

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 2, 2025
@ti-chi-bot
Copy link
Member Author

@D3Hunter This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2025
@D3Hunter D3Hunter changed the title importinto: disable switching to 'import mode' when global sort (#60363) importinto: disable switching to 'import mode' when global sort (#60363) | tidb-test=release-8.1.2 Apr 2, 2025
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 2, 2025
Copy link

ti-chi-bot bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2025
Copy link

ti-chi-bot bot commented Apr 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-02 12:56:50.80545872 +0000 UTC m=+1656304.489694816: ☑️ agreed by Benjamin2037.
  • 2025-04-02 12:57:10.138248445 +0000 UTC m=+1656323.822484541: ☑️ agreed by D3Hunter.

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/release-8.1-gsort-test@0162dfa). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/release-8.1-gsort-test     #60379   +/-   ##
===================================================================
  Coverage                                  ?   71.1999%           
===================================================================
  Files                                     ?       1469           
  Lines                                     ?     424503           
  Branches                                  ?          0           
===================================================================
  Hits                                      ?     302246           
  Misses                                    ?     101682           
  Partials                                  ?      20575           
Flag Coverage Δ
unit 71.1999% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.5268% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot merged commit 2d78446 into pingcap:feature/release-8.1-gsort-test Apr 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants