Skip to content

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Apr 18, 2025

What problem does this PR solve?

Issue Number: close #58822

Problem Summary:

What changed and how does it work?

We delete the memory tracking for received chunk in partial worker. Received chunk in partial worker has been tracked in fetcher, if we receive a smaller chunk compared to the current chunk both held by fetcher and partial worker, memory tracker will double minus the memory usage it tracked. However, duplicate operation will decrease more memory usage and will lead to negative counter in the end.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that getting wrong statistic from memory tracker in hash agg

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/invalid-title do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2025
Copy link

tiprow bot commented Apr 18, 2025

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3903%. Comparing base (ee95b9b) to head (8259670).
Report is 184 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60653        +/-   ##
================================================
+ Coverage   73.0928%   73.3903%   +0.2974%     
================================================
  Files          1716       1750        +34     
  Lines        475412     513933     +38521     
================================================
+ Hits         347492     377177     +29685     
- Misses       106536     114033      +7497     
- Partials      21384      22723      +1339     
Flag Coverage Δ
integration 45.3619% <ø> (?)
unit 72.5158% <ø> (+0.1977%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (+0.1250%) ⬆️
parser ∅ <ø> (∅)
br 43.7193% <ø> (-3.5523%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2025
@xzhangxian1008 xzhangxian1008 changed the title Fix wrong statistic from memory tracker in hash agg executor: fix wrong statistic from memory tracker in hash agg Apr 21, 2025
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2025
@xzhangxian1008
Copy link
Contributor Author

/retest

@xzhangxian1008
Copy link
Contributor Author

/cc @guoshouyan

Copy link

ti-chi-bot bot commented May 21, 2025

@xzhangxian1008: GitHub didn't allow me to request PR reviews from the following users: guoshouyan.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @guoshouyan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented May 21, 2025

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2025
Copy link

ti-chi-bot bot commented May 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-21 01:29:10.32431882 +0000 UTC m=+138787.425486042: ☑️ agreed by windtalker.
  • 2025-05-21 03:24:36.378936961 +0000 UTC m=+145713.480104169: ☑️ agreed by guo-shaoge.

Copy link

tiprow bot commented May 21, 2025

@xzhangxian1008: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 8259670 link true /test tidb_parser_test
fast_test_tiprow 8259670 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xzhangxian1008
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented May 21, 2025

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label May 21, 2025
@ti-chi-bot ti-chi-bot bot merged commit 00efb5f into pingcap:master May 21, 2025
22 of 24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #61228.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

many error log "Memory tracker's counter is invalid"
4 participants