-
Notifications
You must be signed in to change notification settings - Fork 6k
executor: fix wrong statistic from memory tracker in hash agg (#60653) #61228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix wrong statistic from memory tracker in hash agg (#60653) #61228
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #61228 +/- ##
================================================
Coverage ? 57.5232%
================================================
Files ? 1771
Lines ? 632487
Branches ? 0
================================================
Hits ? 363827
Misses ? 244699
Partials ? 23961
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
@gengliqi: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, windtalker, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
This is an automated cherry-pick of #60653
What problem does this PR solve?
Issue Number: close #58822
Problem Summary:
What changed and how does it work?
We delete the memory tracking for received chunk in partial worker. Received chunk in partial worker has been tracked in fetcher, if we receive a smaller chunk compared to the current chunk both held by fetcher and partial worker, memory tracker will double minus the memory usage it tracked. However, duplicate operation will decrease more memory usage and will lead to negative counter in the end.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.