Skip to content

dumpling: return error if init log file failed #60801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

dumpling: return error if init log file failed #60801

merged 3 commits into from
Apr 25, 2025

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Apr 24, 2025

What problem does this PR solve?

Issue Number: close #60689
ref pingcap/log#42

Problem Summary:

What changed and how does it work?

  • upgrade log dependency, so InitAppLogger will return error if no permission

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. component/dumpling This is related to Dumpling of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2025
@tiprow tiprow
Copy link

tiprow bot commented Apr 24, 2025

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joccau joccau added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 24, 2025
@joccau
Copy link
Contributor

joccau commented Apr 24, 2025

/retest

joccau
joccau approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve build CI problem, rest LGTM~

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 24, 2025
lance6716
lance6716 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm, free to unhold after address comment

/hold

please update bazel mirror to let CI build.

dumpling/log/log_test.go Outdated

func TestInitLogNoPermission(t *testing.T) {
// create a temp dir without permissions
tmpDir, err := os.MkdirTemp("", "dumpling-test")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.TempDir()

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 24, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-24 07:42:40.870273192 +0000 UTC m=+514304.682063573: ☑️ agreed by joccau.
  • 2025-04-24 12:21:33.764642874 +0000 UTC m=+531037.576433254: ☑️ agreed by lance6716.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 25, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2025
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 25, 2025

/retest

@tiprow tiprow
Copy link

tiprow bot commented Apr 25, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

make tidy
74abf90 
Signed-off-by: joccau <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5303%. Comparing base (6999c7d) to head (74abf90).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #60801        +/-   ##
================================================
+ Coverage   73.1253%   73.5303%   +0.4050%     
================================================
  Files          1716       1718         +2     
  Lines        475715     479905      +4190     
================================================
+ Hits         347868     352876      +5008     
+ Misses       106479     105604       -875     
- Partials      21368      21425        +57
Flag Coverage Δ
integration 42.7840% <ø> (?)
unit 72.3534% <ø> (+0.0005%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7118% <ø> (+0.0564%) ⬆️
parser ∅ <ø> (∅)
br 46.8396% <ø> (-0.5312%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Benjamin2037
Benjamin2037 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, joccau, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 25, 2025
@ti-chi-bot ti-chi-bot bot merged commit 47e8662 into pingcap:master Apr 25, 2025
27 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 25, 2025
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#60801
7839383 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #60834.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 25, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 26, 2025
@ti-chi-bot
dumpling: return error if init log file failed (#60801) (#60834)
9493b72 
close #60689
Kiran01bm pushed a commit to Kiran01bm/tidb that referenced this pull request Apr 29, 2025
@GMHDBJD @Kiran01bm
dumpling: return error if init log file failed (pingcap#60801)
be95a65 
close pingcap#60689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

+1 more reviewer

@joccau joccau joccau approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dumpling -L save logs in a directory without permission, no error and no log
5 participants
@GMHDBJD @joccau @ti-chi-bot @lance6716 @Benjamin2037