-
Notifications
You must be signed in to change notification settings - Fork 6k
dumpling: return error if init log file failed (#60801) #60834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dumpling: return error if init log file failed (#60801) #60834
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@GMHDBJD This PR has conflicts, I have hold it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, joccau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #60834 +/- ##
================================================
Coverage ? 57.0330%
================================================
Files ? 1770
Lines ? 628939
Branches ? 0
================================================
Hits ? 358703
Misses ? 246032
Partials ? 24204
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
This is an automated cherry-pick of #60801
What problem does this PR solve?
Issue Number: close #60689
ref pingcap/log#42
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.