Skip to content

parser: also reduce literal list with charset #61484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

parser: also reduce literal list with charset #61484

merged 1 commit into from
Jul 3, 2025

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jun 4, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58447

Problem Summary: _charset ?, _charset ?, i.e. list of literal with charset will be converted to ...

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Generate same digest for SQLs with `_charset(xxx), _charset(xxx2),...`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jun 4, 2025

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xhebox xhebox mentioned this pull request Jun 4, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3207%. Comparing base (4c9e2ea) to head (6a63d49).
Report is 20 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #61484        +/-   ##
================================================
+ Coverage   72.9269%   73.3207%   +0.3938%     
================================================
  Files          1740       1740                
  Lines        483048     483091        +43     
================================================
+ Hits         352272     354206      +1934     
+ Misses       109207     107297      -1910     
- Partials      21569      21588        +19
Flag Coverage Δ
integration 42.2680% <ø> (?)
unit 72.1646% <100.0000%> (-0.0028%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3451% <ø> (+0.0127%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xhebox
Copy link
Contributor Author

xhebox commented Jun 5, 2025

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 1, 2025
YangKeao
YangKeao approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-01 02:28:49.390573873 +0000 UTC m=+1361982.113752853: ☑️ agreed by Defined2014.
  • 2025-07-01 02:31:49.198083978 +0000 UTC m=+1362161.921262960: ☑️ agreed by YangKeao.

@xhebox
Copy link
Contributor Author

xhebox commented Jul 1, 2025

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 1, 2025

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xhebox
Copy link
Contributor Author

xhebox commented Jul 1, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 1, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 1, 2025
@xhebox
Copy link
Contributor Author

xhebox commented Jul 1, 2025

/retest

6 similar comments
@Defined2014
Copy link
Contributor

/retest

@Defined2014
Copy link
Contributor

/retest

@Defined2014
Copy link
Contributor

/retest

@Defined2014
Copy link
Contributor

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Jul 2, 2025

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Jul 2, 2025

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Jul 3, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7c785d9 into pingcap:master Jul 3, 2025
24 checks passed
@xhebox
Copy link
Contributor Author

xhebox commented Jul 3, 2025

/cherry-pick release-8.5

@xhebox
Copy link
Contributor Author

xhebox commented Jul 3, 2025

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@xhebox: new pull request created to branch release-8.5: #62176.

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2025
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@xhebox: new pull request created to branch release-7.5: #62177.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2025
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 3, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #62185.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2025
Merged
13 tasks
morgo added a commit to morgo/tidb that referenced this pull request Jul 7, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
414a7a8 
* origin/master: (79 commits)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795)
  *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600)
  tests: update vector cluster test result (pingcap#62174)
  planner: change casetest instance-plan-cache test timeout. (pingcap#62195)
  planner: remove data race for instance plan cache (pingcap#62217)
  *: upgrade pd client to fix keyspace issue (pingcap#62189)
  resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003)
  test: wait for statistics owner to close on exit (pingcap#62198)
  planner: remove the selection above the table dual (pingcap#62193)
  telemetry: add telemetry related code back (pingcap#61753)
  planner: move physical limit related logic into physical op. (pingcap#62187)
  planner: remove useless code (pingcap#61968)
  retry: enhance retry for ingestor on nextgen (pingcap#62191)
  importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138)
  planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068)
  ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151)
  planner: skip empty expression in the applyPredicateSimplification (pingcap#62178)
  codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175)
  parser: also reduce literal list with charset (pingcap#61484)
  ...
morgo added a commit to morgo/tidb that referenced this pull request Jul 7, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
23bc18d 
* origin/master: (79 commits)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795)
  *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600)
  tests: update vector cluster test result (pingcap#62174)
  planner: change casetest instance-plan-cache test timeout. (pingcap#62195)
  planner: remove data race for instance plan cache (pingcap#62217)
  *: upgrade pd client to fix keyspace issue (pingcap#62189)
  resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003)
  test: wait for statistics owner to close on exit (pingcap#62198)
  planner: remove the selection above the table dual (pingcap#62193)
  telemetry: add telemetry related code back (pingcap#61753)
  planner: move physical limit related logic into physical op. (pingcap#62187)
  planner: remove useless code (pingcap#61968)
  retry: enhance retry for ingestor on nextgen (pingcap#62191)
  importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138)
  planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068)
  ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151)
  planner: skip empty expression in the applyPredicateSimplification (pingcap#62178)
  codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175)
  parser: also reduce literal list with charset (pingcap#61484)
  ...
morgo added a commit to morgo/tidb that referenced this pull request Jul 7, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
f645f5b 
* origin/master: (79 commits)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795)
  *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600)
  tests: update vector cluster test result (pingcap#62174)
  planner: change casetest instance-plan-cache test timeout. (pingcap#62195)
  planner: remove data race for instance plan cache (pingcap#62217)
  *: upgrade pd client to fix keyspace issue (pingcap#62189)
  resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003)
  test: wait for statistics owner to close on exit (pingcap#62198)
  planner: remove the selection above the table dual (pingcap#62193)
  telemetry: add telemetry related code back (pingcap#61753)
  planner: move physical limit related logic into physical op. (pingcap#62187)
  planner: remove useless code (pingcap#61968)
  retry: enhance retry for ingestor on nextgen (pingcap#62191)
  importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138)
  planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068)
  ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151)
  planner: skip empty expression in the applyPredicateSimplification (pingcap#62178)
  codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175)
  parser: also reduce literal list with charset (pingcap#61484)
  ...
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 7, 2025
@xhebox xhebox added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Jul 7, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 7, 2025
@ti-chi-bot
parser: also reduce literal list with charset (#61484) (#62177)
360ad51 
close #58447
ti-chi-bot bot pushed a commit that referenced this pull request Jul 8, 2025
@ti-chi-bot
parser: also reduce literal list with charset (#61484) (#62176)
d133bd7 
close #58447
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2025
@ti-chi-bot
parser: also reduce literal list with charset (#61484) (#62185)
d5856a6 
close #58447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
approved compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple digests being generated based on variation in number of elements in "IN" clause on binary column for semantically similar query
5 participants
@xhebox @Defined2014 @ti-chi-bot @YangKeao @tangenta