planner: remove the selection above the table dual #62193

hawkingrei · 2025-07-03T11:00:37Z

What problem does this PR solve?

Issue Number: close #62192

Problem Summary:

What changed and how does it work?

if the tableDual is with the rowcount=1, the selection above it is useless.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2025-07-03T15:34:14Z

pkg/planner/core/casetest/rule/testdata/outer2inner_out.json

@@ -514,8 +514,7 @@
          "├─TableReader(Build) 10000.00 root  data:TableFullScan",
          "│ └─TableFullScan 10000.00 cop[tikv] table:inner_t1 keep order:false, stats:pseudo",
          "└─HashJoin(Probe) 10000.00 root  left outer join, left side:TableReader, equal:[eq(test.ti.i, test.ti.i)]",
-          "  ├─Selection(Build) 0.00 root  not(isnull(test.ti.i))",
-          "  │ └─TableDual 0.00 root  rows:0",
+          "  ├─TableDual(Build) 0.00 root  rows:0",
          "  └─TableReader(Probe) 10000.00 root  data:TableFullScan",
          "    └─TableFullScan 10000.00 cop[tikv] table:ti keep order:false, stats:pseudo"
        ]


+-----------------------------------------------------------------------------------------------------------------------------------------------------+ | EXPLAIN | +-----------------------------------------------------------------------------------------------------------------------------------------------------+ | -> Hash antijoin (no condition) (cost=0.25 rows=0) (actual time=2.171..2.171 rows=0 loops=1) | | -> Left hash join (no condition) (cost=0.25 rows=0) (actual time=2.155..2.155 rows=0 loops=1) | | -> Table scan on ti (cost=0.35 rows=1) (actual time=2.145..2.145 rows=0 loops=1) | | -> Hash | | -> Zero rows (Impossible filter) (cost=0.00..0.00 rows=0) (actual time=0.000..0.000 rows=0 loops=1) | | -> Hash | | -> Zero rows (Join condition (inner_t1.i = ti.i) requires pruned table) (cost=0.00..0.00 rows=0) (actual time=0.000..0.000 rows=0 loops=1) | +-----------------------------------------------------------------------------------------------------------------------------------------------------+

It is mysql's plan

codecov · 2025-07-03T15:49:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9860%. Comparing base (be0ce88) to head (a65f24e).
Report is 8 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #62193        +/-   ##
================================================
+ Coverage   72.9276%   73.9860%   +1.0583%     
================================================
  Files          1740       1748         +8     
  Lines        483076     489852      +6776     
================================================
+ Hits         352296     362422     +10126     
+ Misses       109184     106063      -3121     
+ Partials      21596      21367       -229

Flag	Coverage Δ
integration	`43.2744% <100.0000%> (?)`
unit	`72.8429% <100.0000%> (+0.6658%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7804% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.3553% <ø> (+0.0639%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hawkingrei · 2025-07-03T16:20:14Z

/retest

King-Dylan

/lgtm

ti-chi-bot · 2025-07-04T02:49:21Z

[LGTM Timeline notifier]

Timeline:

2025-07-04 01:49:35.68151552 +0000 UTC m=+1618828.404694499: ☑️ agreed by King-Dylan.
2025-07-04 02:49:20.667927399 +0000 UTC m=+1622413.391106437: ☑️ agreed by qw4990.

hawkingrei · 2025-07-04T03:19:13Z

/hold

ti-chi-bot · 2025-07-04T03:25:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, King-Dylan, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,King-Dylan,qw4990]
~~pkg/planner/OWNERS~~ [AilinKid,King-Dylan,qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hawkingrei · 2025-07-04T03:25:28Z

/unhold

hawkingrei · 2025-07-04T04:21:17Z

/retest

hawkingrei · 2025-07-04T05:05:31Z

/retest

hawkingrei · 2025-07-04T05:06:34Z

/retest

* origin/master: (79 commits) backend/local: add rate limiter for split region and ingest data (pingcap#61555) fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795) *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600) tests: update vector cluster test result (pingcap#62174) planner: change casetest instance-plan-cache test timeout. (pingcap#62195) planner: remove data race for instance plan cache (pingcap#62217) *: upgrade pd client to fix keyspace issue (pingcap#62189) resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003) test: wait for statistics owner to close on exit (pingcap#62198) planner: remove the selection above the table dual (pingcap#62193) telemetry: add telemetry related code back (pingcap#61753) planner: move physical limit related logic into physical op. (pingcap#62187) planner: remove useless code (pingcap#61968) retry: enhance retry for ingestor on nextgen (pingcap#62191) importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138) planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068) ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151) planner: skip empty expression in the applyPredicateSimplification (pingcap#62178) codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175) parser: also reduce literal list with charset (pingcap#61484) ...

fix

3a71e12

Signed-off-by: Weizhen Wang <[email protected]>

fix

ff22070

Signed-off-by: Weizhen Wang <[email protected]>

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2025

hawkingrei added 4 commits July 3, 2025 19:09

fix

c74a2e5

Signed-off-by: Weizhen Wang <[email protected]>

planner: RegardNULLAsPoint should be true as default

57025c3

Signed-off-by: Weizhen Wang <[email protected]>

planner: RegardNULLAsPoint should be true as default

bfaa5b6

Signed-off-by: Weizhen Wang <[email protected]>

update

a65f24e

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei commented Jul 3, 2025

View reviewed changes

hawkingrei changed the title ~~planner: remove the selection with the table dual~~ planner: remove the selection above the table dual Jul 4, 2025

King-Dylan approved these changes Jul 4, 2025

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2025

hawkingrei requested a review from AilinKid July 4, 2025 02:00

qw4990 approved these changes Jul 4, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2025

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025

AilinKid approved these changes Jul 4, 2025

View reviewed changes

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025

ti-chi-bot bot merged commit 1a3bb65 into pingcap:master Jul 4, 2025
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

planner: remove the selection above the table dual #62193

planner: remove the selection above the table dual #62193

Uh oh!

hawkingrei commented Jul 3, 2025 •

edited

Loading

Uh oh!

hawkingrei Jul 3, 2025

Uh oh!

codecov bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

hawkingrei commented Jul 3, 2025

Uh oh!

King-Dylan left a comment

Uh oh!

ti-chi-bot bot commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

ti-chi-bot bot commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

planner: remove the selection above the table dual #62193

planner: remove the selection above the table dual #62193

Uh oh!

Conversation

hawkingrei commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

hawkingrei Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hawkingrei commented Jul 3, 2025

Uh oh!

King-Dylan left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Jul 4, 2025

[LGTM Timeline notifier]

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

ti-chi-bot bot commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

hawkingrei commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

hawkingrei commented Jul 3, 2025 •

edited

Loading

codecov bot commented Jul 3, 2025 •

edited

Loading