Skip to content

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Jun 20, 2025

What problem does this PR solve?

Issue Number: close #60926

Problem Summary:

What changed and how does it work?

We replace Call with WithRecovery in the close of hash join v1.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that the panic in the close of hash join v1 is not recovered

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 20, 2025
@xzhangxian1008 xzhangxian1008 changed the title Replica Call with CallWithRecover in the close of hash join v1 Replace Call with CallWithRecover in the close of hash join v1 Jun 20, 2025
Copy link

tiprow bot commented Jun 20, 2025

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 20, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 20, 2025
@xzhangxian1008 xzhangxian1008 changed the title Replace Call with CallWithRecover in the close of hash join v1 executor: replace Call with CallWithRecover in the close of hash join v1 Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.9810%. Comparing base (1040e03) to head (b614712).
Report is 142 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61868        +/-   ##
================================================
- Coverage   73.0288%   72.9810%   -0.0479%     
================================================
  Files          1730       1753        +23     
  Lines        481656     508376     +26720     
================================================
+ Hits         351748     371018     +19270     
- Misses       108355     115338      +6983     
- Partials      21553      22020       +467     
Flag Coverage Δ
integration 42.5275% <50.0000%> (?)
unit 72.2274% <75.0000%> (-0.0497%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 44.7585% <ø> (-1.8066%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2025
@xzhangxian1008 xzhangxian1008 deleted the fix-60926 branch July 10, 2025 06:34
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #62341.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #62342.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #62343.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jul 10, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #62345.
But this PR has conflicts, please resolve them!

@xzhangxian1008 xzhangxian1008 changed the title executor: replace Call with CallWithRecover in the close of hash join v1 executor: replace Call with `WithRecovery in the close of hash join v1 Jul 10, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 16, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 16, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 16, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jul 16, 2025
@xzhangxian1008
Copy link
Contributor Author

/cherrypick release-6.5-20250805-v6.5.12

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 5, 2025
@ti-chi-bot
Copy link
Member

@xzhangxian1008: new pull request created to branch release-6.5-20250805-v6.5.12: #62827.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-6.5-20250805-v6.5.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child executors can not be closed when panic happens in the Close function
6 participants